Closed
Bug 965651
Opened 11 years ago
Closed 6 years ago
Convert more Add-ons Manager code to consistently use Components.Exception
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
INACTIVE
People
(Reporter: Unfocused, Unassigned)
References
Details
Followup from bug 759642.
The Add-ons Manager is a bit inconsistent in the way it throws exceptions:
* throw Components.Exception(...)
* throw new Error(...)
* throw Components.results.whatever
Ideally, it should always use Components.Exception. See bug 746908 and bug 759642 for examples of it's usage.
The relevant files are under: /toolkit/mozapps/extensions/
And some documentation on Components.Exception:
https://developer.mozilla.org/en/Components.Exception
This query should show where we're throwing any exception:
http://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=%22throw+%22+path%3Atoolkit%2Fmozapps%2Fextensions%2F&redirect=true
From that, it seems what's left is:
* XPIProvider.jsm & XPIProviderUtils.js
* Tests
So it'd make most sense to have one patch for each of those bulletpoints.
Reporter | ||
Comment 1•11 years ago
|
||
Amod, did you want to work on this?
Flags: needinfo?(amod.narvekar)
Comment 2•11 years ago
|
||
Hi Bliar, Thank you very much for asking me to work on the bug.
Currently I am busy with my academics and would resume with bugzilla by 1st week of March.
If you are ready to wait, I will be extremely obliged.
Flags: needinfo?(amod.narvekar)
Comment 3•6 years ago
|
||
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•