Closed Bug 965690 Opened 11 years ago Closed 10 years ago

Caret disappears in Rich text editor after modal dialog closing

Categories

(Core :: DOM: Editor, defect)

28 Branch
x86_64
All
defect
Not set
major

Tracking

()

RESOLVED DUPLICATE of bug 956704
Tracking Status
firefox27 --- unaffected
firefox28 - affected
firefox29 - affected
firefox30 - affected

People

(Reporter: alice0775, Unassigned)

References

Details

(Keywords: regression)

Build identifier:
http://hg.mozilla.org/mozilla-central/rev/7e79536aca0a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140129030602
http://hg.mozilla.org/releases/mozilla-aurora/rev/7d1173c4b173
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20140129004017

Steps To Reproduce:
1. Open http://www-archive.mozilla.org/editor/midasdemo/
2. Attempt to input text
   --- Observe, caret
3. Click "Insert Link" Icon
4. Close modal dialog
5. Attempt to input text
   --- Observe, caret

Actual Results:
Caret is not displayed anymore

Expected Results:
Caret should be displayed


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cbe04dbc2bd6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131217160921
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/08dc60299942
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131217161358
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cbe04dbc2bd6&tochange=08dc60299942

Regresseed by:
08dc60299942	Blake Kaplan — Bug 933483 - Don't fire events (and especially request animation frame events) when we're in a modal dialog. r=smaug
Blocks: 965673
Hmm, do we need to invalidate the caret somehow when exiting modal state?
Just want to make sure this is on your radar
Flags: needinfo?(mrbkap)
padenot's debugging in bug 956704 shows that we mess up focus and blur events after (non-tab-modal) alerts. The patch I'm working on for that bug should fix this one as well.
Depends on: 956704
Flags: needinfo?(mrbkap)
FWIW bug 969773 recently fixed one way that the editor messed things up when it did not receive the focus and blur events in the expected order.
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailapocalypse) from comment #4)
> FWIW bug 969773 recently fixed one way that the editor messed things up when
> it did not receive the focus and blur events in the expected order.

Ehsan, should we be considering the fix in that bug for uplift to Aurora/Beta in that case?
Flags: needinfo?(ehsan)
(In reply to Lukas Blakk [:lsblakk] from comment #5)
> (In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
> emailapocalypse) from comment #4)
> > FWIW bug 969773 recently fixed one way that the editor messed things up when
> > it did not receive the focus and blur events in the expected order.
> 
> Ehsan, should we be considering the fix in that bug for uplift to
> Aurora/Beta in that case?

Hmm, well, that bug is not a regression, but perhaps it's safe to uplift it to Aurora?  I wouldn't recommend uplifting it to Beta.  Will ask from Mats on the bug too.
Flags: needinfo?(ehsan)
Ehsan, any news on this bug ? thanks
Flags: needinfo?(ehsan)
Bug 956704 seems to have fixed this.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(ehsan)
Resolution: --- → DUPLICATE
since were tracking the dupe I'll drop tracking on this.
You need to log in before you can comment on or make changes to this bug.