Closed
Bug 965832
Opened 11 years ago
Closed 11 years ago
Nav bar selection monocles don't appear when tapping text
Categories
(Firefox for Metro Graveyard :: Input, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 29
People
(Reporter: jimm, Assigned: jimm)
References
Details
(Keywords: regression, Whiteboard: [defect] p=1)
Attachments
(2 files, 2 obsolete files)
|
(deleted),
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
STR:
1) type some text in the nav bar with the keyboard
2) tap the text
expected: skb is displayed, text is selected, and selection monocles come up
result: no selection monocles
We have a test for this which isn't failing although we won't get the soft keyboard in automated tests.
|
||
Updated•11 years ago
|
Blocks: metrov1backlog
Whiteboard: [triage] [defect] p=0
|
Assignee | |
Comment 1•11 years ago
|
||
They appear, they just remain hidden. I'll see if I can add a test for this too.
Attachment #8368007 -
Flags: review?(mbrubeck)
|
|
Assignee | |
Comment 2•11 years ago
|
||
oops, ignore all that debug gunk.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8368007 -
Attachment is obsolete: true
Attachment #8368007 -
Flags: review?(mbrubeck)
Attachment #8368009 -
Flags: review?(mbrubeck)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8368009 [details] [diff] [review]
fix
This can be cleaned up even further.
Attachment #8368009 -
Flags: review?(mbrubeck)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8368009 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Comment 7•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8368146 -
Flags: review?(mbrubeck)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8368146 -
Flags: review?(mbrubeck)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8368147 -
Flags: review?(mbrubeck)
|
||
Updated•11 years ago
|
Attachment #8368146 -
Flags: review?(mbrubeck) → review+
|
|
||
Updated•11 years ago
|
Attachment #8368147 -
Flags: review?(mbrubeck) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: regressionwindow-wanted
|
|
||
Comment 9•11 years ago
|
||
Hey Jim, can you provide a point value.
Status: NEW → ASSIGNED
Flags: needinfo?(jmathies)
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [triage] [defect] p=0 → [defect] p=0
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(jmathies)
Whiteboard: [defect] p=0 → [defect] p=1
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd164c7bddb0
https://hg.mozilla.org/mozilla-central/rev/1e679dc9033c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
||
Comment 11•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Verified as fixed with a Surface Pro 2 device on latest Aurora (build ID: 20140206004003).
The selection monocles are now properly displayed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•