Closed Bug 965856 Opened 11 years ago Closed 7 years ago

SourceMap.jsm not invisible to debugger

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: past, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [chrome-debug])

We have some bugs on file already about automatic pretty-printing not playing nice with chrome debugging (bad heuristics), but they expose another bug: stepping on a pretty-printed (source-mapped) file will pause in source map library frames out of nowhere. STR: !) Open the debugger on a bugzilla page. 3) Open the browser debugger and select debugger-controller.js 4) Set a breakpoint at line 296 (onTabNavigated). 5) Reload the bugzilla page. 6) Step in for a bit and you will get to pause on SourceMap.jsm:410 This seems like the same problem we faced with the promise library back in the day, which was fixed by loading the library using loadSubscript instead of Cu.import.
Priority: -- → P3
If Panos is right, the proper fix for this would be to convert SourceMap.jsm to an SDK module. The devtools loader will automatically mark modules as invisible to the debugger. Bug 935366 might be relevant for this.
I think this should technically belong to the source maps meta bug, since the problem is presumably with SourceMap.jsm.
Summary: Stepping in chrome code gets into source map frames → SourceMap.jsm is not invisible to debugger
Summary: SourceMap.jsm is not invisible to debugger → SourceMap.jsm not invisible to debugger
Depends on: 935366
This is going to be fixed by bug 935366, which drop the jsm in favor of a regular commonjs module.
SourceMap.jsm is gone now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.