custom.firefox.lady [:tawn] Reporter
	Description • 11 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140125004003

Steps to reproduce:

1. Open and close some tabs (so there is available history if starting with new profile)
2. Click the Australis PanelUI button
3. Click History
4. Ctrl + left click a history item (one below the 'Restore all tabs' entry)


Actual results:

Two new (duplicate) tabs are opened for the selected history item


Expected results:

The history item (url) should be opened in one new tab, not two.

	Alice0775 White
	Comment 1 • 11 years ago

history item, not recently closed tab item

	:Gijs (he/him) Assignee
	Comment 2 • 11 years ago

(In reply to Alice0775 White from comment #1)
> history item, not recently closed tab item

Comment #0 says:

"4. Ctrl + left click a history item (one below the 'Restore all tabs' entry)"

On latest nightly, that implies it's a recently closed tab. At this point I'm just confused - does it happen with all of these or only some, and which is it?

	Alice0775 White
	Comment 3 • 11 years ago

Regressed by bug 927917

	custom.firefox.lady [:tawn] Reporter
	Comment 4 • 11 years ago

(In reply to :Gijs Kruitbosch from comment #2)
> (In reply to Alice0775 White from comment #1)
> > history item, not recently closed tab item
> 
> Comment #0 says:
> 
> "4. Ctrl + left click a history item (one below the 'Restore all tabs'
> entry)"
> 
> On latest nightly, that implies it's a recently closed tab. At this point
> I'm just confused - does it happen with all of these or only some, and which
> is it?

I reported this bug from testing on the 2014-01-30 build. The entries have since changed/moved on the 2014-01-31 nightly. The recently closed tabs entries work fine. The bug occurs in the history section that currently appears near the bottom of the panel, just above 'Show all History'.

	:Gijs (he/him) Assignee
	Comment 5 • 11 years ago

In fact, as best I can tell bug 927917 comment 3 was wrong, and both command and click fire here. Just handling clicks is fine, so let's just do that instead.

	:Gijs (he/him) Assignee
	Comment 6 • 11 years ago

Comment on attachment 8369981 [details] [diff] [review]
fix ctrl-clicks in Australis history view,

remote:   https://hg.mozilla.org/integration/fx-team/rev/58c0d6666784

	Carsten Book [:Tomcat]
	Comment 7 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/58c0d6666784

	Sylvestre Ledru [:Sylvestre]
	Comment 8 • 11 years ago

Gijs, could you fill the [Approval Request Comment] ? Thanks

	:Gijs (he/him) Assignee
	Comment 9 • 11 years ago

Comment on attachment 8369981 [details] [diff] [review]
fix ctrl-clicks in Australis history view,

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> Gijs, could you fill the [Approval Request Comment] ? Thanks

Huh. Not sure what happened there. Sorry! But toggling it now doesn't seem to prefill it... let me clear it and put it back. :-\

	:Gijs (he/him) Assignee
	Comment 10 • 11 years ago

Comment on attachment 8369981 [details] [diff] [review]
fix ctrl-clicks in Australis history view,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: ctrl-clicking items in the history view opens a tab too many
Testing completed (on m-c, etc.): local, m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

	:Gijs (he/him) Assignee
	Comment 11 • 11 years ago

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/58a388ac2a40

	Bogdan Maris, Desktop QA
	Comment 12 • 10 years ago

Verified as fixed in latest Aurora 29.0a2 and latest Nightly 30.0a1 using Windows 7 32bit. Only one item is opened in a new tab.