Closed
Bug 966210
Opened 11 years ago
Closed 11 years ago
When enabled, B2G devtools layers should instantly work for apps that are already running.
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: janx, Assigned: janx)
References
Details
(Keywords: verifyme, Whiteboard: [qa+])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
janx
:
review+
|
Details | Diff | Splinter Review |
Observed: When enabling "Settings > Developer > Show devtools overlay", an overlay is shown over apps when they are being started.
Expected: Not only should it work for apps that are later started, but also for apps that were already running when the setting was enabled.
To achieve this, the devtools layers should query the list of running apps and track them. This can be done by extracting the `listRunningApps` method of the webappsActor.
Assignee | ||
Updated•11 years ago
|
Blocks: devtools-layers
No longer depends on: devtools-layers
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8371311 -
Flags: review?(poirot.alex)
Comment 2•11 years ago
|
||
Comment on attachment 8371311 [details] [diff] [review]
Make B2G devtools layers track all running apps on init.
Review of attachment 8371311 [details] [diff] [review]:
-----------------------------------------------------------------
Shouldn't we also track the system app?
Attachment #8371311 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thanks for the review! We currently don't track the system app, because we first need to figure out a good place to display its metrics information. (The bottom right on the home screen is already used by the home screen, maybe inside the drop-down menu?)
Keywords: checkin-needed
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8371311 -
Attachment is obsolete: true
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8371384 [details] [diff] [review]
Make B2G devtools layers track all running apps on init.
Review of attachment 8371384 [details] [diff] [review]:
-----------------------------------------------------------------
Replaced stray `var` with a `let`, carrying over Alex's r+.
Attachment #8371384 -
Flags: review+
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8371384 -
Attachment is obsolete: true
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8371387 [details] [diff] [review]
Make B2G devtools layers track all running apps on init. r=ochameau
Appended "r=ochameau" to commit message.
Attachment #8371387 -
Flags: review+
Comment 8•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•