Closed
Bug 966282
Opened 11 years ago
Closed 11 years ago
Scrolling in the Firefox marketplace is significantly worse in Nightly (29) & Aurora (28) than GA (26)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox26 unaffected, firefox27 unaffected, firefox28 fixed, firefox29 fixed, fennec28+)
VERIFIED
FIXED
Firefox 29
Tracking | Status | |
---|---|---|
firefox26 | --- | unaffected |
firefox27 | --- | unaffected |
firefox28 | --- | fixed |
firefox29 | --- | fixed |
fennec | 28+ | --- |
People
(Reporter: deb, Assigned: botond)
References
()
Details
(Keywords: regression, reproducible)
Attachments
(3 files, 2 obsolete files)
kats and mbrubeck suggested this might be a regression of bug 893236. Either way, scrolling is close to unusably bad on Marketplace right now.
Reporter | ||
Updated•11 years ago
|
tracking-fennec: --- → ?
Updated•11 years ago
|
Comment 1•11 years ago
|
||
Last good revision: 7e79536aca0a (2014-01-29) First bad revision: 73eefb421e2a (2014-01-30) Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7e79536aca0a&tochange=73eefb421e2a I'd like to say bug 961280.
Blocks: 961280
status-firefox26:
--- → unaffected
status-firefox27:
--- → unaffected
status-firefox28:
--- → affected
status-firefox29:
--- → affected
Flags: needinfo?(bugmail.mozilla)
Keywords: regression,
reproducible
Comment 2•11 years ago
|
||
I don't believe bug 961280 should affect anything on Fennec; the code isn't used there. Can we narrow the range further with inbound builds?
Flags: needinfo?(bugmail.mozilla)
Comment 3•11 years ago
|
||
changeset: 165664:4f0d8916386e user: Botond Ballo <botond@mozilla.com> date: Mon Jan 27 19:51:35 2014 -0500 summary: Bug 962791 - Do not wrap a position:absolute item into a ScrollLayer item if its containing block if outside the scrolled frame. r=roc
Assignee | ||
Comment 4•11 years ago
|
||
Assignee: nobody → botond
Flags: needinfo?(botond)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #8368790 -
Flags: feedback?(tnikkel)
Comment 6•11 years ago
|
||
Sarah - Can someone check to see if this happens on FxOS?
Flags: needinfo?(sparsons)
Updated•11 years ago
|
QA Contact: mvaughan
Comment 7•11 years ago
|
||
I would expect this problem to affect b2g as well in general (although possibly not for this one specific site).
Comment 8•11 years ago
|
||
I am seeing an issue with scrolling, but it isn't throughout the Marketplace app. When scrolling up or down near or on the 'Featured Apps' area, the scrolling becomes pretty choppy. This occurred on a Buri and Helix on their respective 01/31/14 1.3 and Master(1.4) builds. I have attached a video of the issue occurring on a Buri with 1.3. The scrolling is quick to show the choppiness, but this will occur no matter what speed the user scrolls. The scrolling became much smoother once I got a little away from the top of the screen, even after selecting 'More' at the bottom to load more apps to view. Scrolling remained pretty smooth when navigating to other areas of the Marketplace app. - Buri 1.3 build - Device: Buri v1.3 MOZ RIL BuildID: 20140131004001 Gaia: 0ddcd8da5bfe1b48c73502ef29220e92f2db6b73 Gecko: 32e45047b663 Version: 28.0a2 Firmware Version: V1.2-device.cfg
Flags: needinfo?(sparsons)
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #8368768 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
Attachment #8368790 -
Attachment is obsolete: true
Attachment #8368790 -
Flags: feedback?(tnikkel)
+ nsLayoutUtils::IsProperAncestorFrame(mScrolledFrame, aItem->Frame(), nullptr); I think IsProperAncestorFrame should be IsAncestorFrameCrossDoc. Does that help?
Comment 12•11 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #11) > + nsLayoutUtils::IsProperAncestorFrame(mScrolledFrame, > aItem->Frame(), nullptr); > > I think IsProperAncestorFrame should be IsAncestorFrameCrossDoc. Does that > help? The patch means we no longer wrap a fixed position item, and it is between two scroll layer items, causing us to fail to merge scroll layer items into one. I think it is correct that we are no longer wrapping this fixed position item.
Assignee | ||
Comment 13•11 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #11) > + nsLayoutUtils::IsProperAncestorFrame(mScrolledFrame, > aItem->Frame(), nullptr); > > I think IsProperAncestorFrame should be IsAncestorFrameCrossDoc. Does that > help? I tried it - it does not help.
I guess this bug is going to be fixed by backout of bug 962791. Let's talk over there.
Comment 15•11 years ago
|
||
Fixed via backout in bug 962791.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → Firefox 29
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
tracking-fennec: ? → 28+
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•