Closed
Bug 966348
Opened 11 years ago
Closed 11 years ago
Rename Promise.cast to Promise.resolve
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: annevk, Assigned: nsm)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
And remove the existing Promise.resolve. Based on TC39 consensus reached yesterday. (No public pointer yet.)
Down the road we can probably simplify the internal model due to this change as well, but I guess for now it's mostly important not to expose soon-to-be-legacy API.
Comment 1•11 years ago
|
||
According to <https://github.com/rwaldron/tc39-notes/blob/master/es6/2014-01/jan-30.md#conclusionresolution-3> and as noted in the es-discuss list, I think this change can now proceed and be uplifted to Aurora.
In the unlikely case that a new consensus arises in the future for which "cast" is reintroduced, it will be easier to add a new method than remove an existing one. (The potential loss of the "resolve" optimization following the reintroduction of "cast" is an internal detail that would be transparent to all real-world consumers.)
status-firefox29:
--- → affected
status-firefox30:
--- → affected
tracking-firefox29:
--- → ?
tracking-firefox30:
--- → ?
Comment 2•11 years ago
|
||
Please consider a patch to make sure it reaches Aurora quickly.
Promise was part of the highlight of the release notes:
https://www.mozilla.org/en-US/firefox/29.0a2/auroranotes/
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8373419 -
Flags: review?(bzbarsky)
Comment 4•11 years ago
|
||
Comment on attachment 8373419 [details] [diff] [review]
Rename Promise.cast to Promise.resolve.
r=me
Attachment #8373419 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Reporter | ||
Updated•11 years ago
|
Keywords: dev-doc-needed
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8373419 [details] [diff] [review]
Rename Promise.cast to Promise.resolve.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
DOM Promises
User impact if declined:
We'd ship a implementation that has just been obsoleted in the spec.
Testing completed (on m-c, etc.):
Yes
Risk to taking this patch (and alternatives if risky):
None, it's just dropping a method that we haven't shipped to anything beyond a Aurora
String or IDL/UUID changes made by this patch:
None
Attachment #8373419 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8373419 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•11 years ago
|
||
Comment 9•11 years ago
|
||
Do we have a bug to rehost/"nativize" in SpiderMonkey?
Thanks for tracking the ES6 promises twists and turns here.
/be
Reporter | ||
Comment 10•11 years ago
|
||
That is bug 911216. We don't really have a plan for that yet because we a) lack an event loop and b) the main benefit would be better subclassing support which we don't have yet.
Comment 11•8 years ago
|
||
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•