After bug 878805, in account settings -> Copies & folders it can happen that some of the folder pickers show the "Choose folder". I experience it on the Archive setting. The STRs are this: 1. click "Keep message archives in" 2. click "Other" when the picker besides it shows "Choose folder..." 3. click OK. Actual result: No error from TB. I have not checked what folder is stored into the prefs, but it is not important, it must be wrong as I have not chosen anything. Upon reopening Account manager, all the settings are preserved, even the undefined "Choose folder...". Expected result: Something that the user knows which folder gets saved when he clicks OK. Probably the original behaviour unless something else is agreed upon with an Account manager owner and not random reviewers.

We could probably disable the Ok button until the form fields are valid.

This could happen if the default folder doesn't exist (or in the case of IMAP, hasn't been discovered and/or subscribed); it will get created on demand. Under the old picker the first server would be selected, but it was just as meaningless.

(In reply to Jim Porter from comment #1) > We could probably disable the Ok button until the form fields are valid. What happens if you switch to a different account page?

sure, i'll clean up after my bug. (In reply to :aceman from comment #0) > and not random reviewers. your campaign here and elsewhere is really rather sad. i suggest you knock it off and focus on the general and timely forward improvement of the codebase rather than silo thinking.

i suggest the trivial fix here would be to select the default radio button, if upon display of the page, a particular menulist has no chosen folder, ie menulist.selectedItem == null. exiting the dialog with no folder selection for a particular selected radio doesn't affect the default stored in prefs. thoughts?

Comment on attachment 8394398 [details] [diff] [review] acctfolderpicker.patch Review of attachment 8394398 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/base/prefs/content/am-copies.js @@ +280,5 @@ > + uri = document.getElementById(folderPickerId).folder.URI; > + } > + else { > + // No folder selected, revert to default. > + radioElemChoice = 0; It looks like radioElemChoice starts out as a string. We should keep it as a string (not that it breaks anything, since setAttribute below will stringify it). @@ +285,5 @@ > + uri = document.getElementById(accountPickerId).folder.URI; > + if (uri) { > + // Create Folder URI > + uri = uri + folderSuffix; > + } This code is duplicated from above. I think we should try to merge the two so it's only in one spot.

Comment on attachment 8402780 [details] [diff] [review] acctfolderpicker.patch Review of attachment 8402780 [details] [diff] [review]: ----------------------------------------------------------------- This seems good to me. Thanks!