Closed
Bug 966695
Opened 11 years ago
Closed 11 years ago
BytecodeEmitter.cpp:5169:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: Benjamin, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
/home/benjamin/dev/mozilla/inbound/js/src/frontend/BytecodeEmitter.cpp: In function ‘bool EmitReturn(js::ExclusiveContext*, js::frontend::BytecodeEmitter*, js::frontend::ParseNode*)’:
/home/benjamin/dev/mozilla/inbound/js/src/frontend/BytecodeEmitter.cpp:5169:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Here is a rather verbose, if explicit, fix.
Attachment #8369133 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8369133 [details] [diff] [review]
fix warning
Review of attachment 8369133 [details] [diff] [review]:
-----------------------------------------------------------------
Oops, I created this? :-( As a quick fix, okay.
Really all these offsets should be unsigned, but that's rather more involved, and might well mean touching many uses of offset() everywhere, so we can do that later.
Attachment #8369133 -
Flags: review?(jwalden+bmo) → review+
|
Reporter | |
Comment 2•11 years ago
|
||
Yeah, making the opcode length macros using constexpr with explicit size_t is what upset GCC.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfad58dd98b6
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•