Closed
Bug 966942
Opened 11 years ago
Closed 11 years ago
Cu.cloneInto fails cloning nsIDOMPaymentRequestInfo
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ferjm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Still waiting for try results.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8369461 [details] [diff] [review]
payment.patch
https://tbpl.mozilla.org/?tree=Try&rev=997c222c6cbc
Attachment #8369461 -
Flags: review?(ferjmoreno)
Attachment #8369461 -
Flags: review?(bzbarsky)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8369461 [details] [diff] [review]
payment.patch
Why do we even need the nsIDOMPaymentRequestInfo dictionary? Seems unused...
r=me with that nuked as well, as I suspect is can be.
Attachment #8369461 -
Flags: review?(bzbarsky) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8369461 [details] [diff] [review]
payment.patch
Review of attachment 8369461 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Andrea!
You still need to remove PaymentRequestInfo.js from moz.build, manifest and package-installer.in files
https://mxr.mozilla.org/mozilla-central/search?string=PaymentRequestInfo
|
|
||
Updated•11 years ago
|
Attachment #8369461 -
Flags: review?(ferjmoreno)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8369461 -
Attachment is obsolete: true
Attachment #8369999 -
Flags: review?(ferjmoreno)
|
|
||
Updated•11 years ago
|
Attachment #8369999 -
Flags: review?(ferjmoreno) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Assignee: nobody → amarchesini
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•