As soon as Image and Canvas layers are not using deprecated code on all platforms we can remove a whole bunch of deprecated code.

Comment on attachment 8369433 [details] [diff] [review] Remove a lot of deprecated code Review of attachment 8369433 [details] [diff] [review]: ----------------------------------------------------------------- I am excite! A few minor comments, msotly style. They're all with TYCbCrImage, so maybe just replace all those with a MOZ_ASSERT(foo != TYCbCrImage) at the start of the functions? ::: gfx/layers/basic/BasicCompositor.cpp @@ +210,5 @@ > uint32_t aTextureFlags) > { > RefPtr<DeprecatedTextureHost> result = nullptr; > if (aDescriptorType == SurfaceDescriptor::TYCbCrImage) { > + MOZ_CRASH("Should be using non-deprecated textures"); any reason to have this here at all, instead of just getting rid of the if block entirely and leaving the else block with the MOZ_ASSERT? With the message in the MOZ_ASSERT changed to something more appropriate. ::: gfx/layers/d3d11/TextureD3D11.cpp @@ +418,5 @@ > uint32_t aTextureFlags) > { > RefPtr<DeprecatedTextureHost> result; > if (aDescriptorType == SurfaceDescriptor::TYCbCrImage) { > + MOZ_CRASH("Should be using non-deprecated textures"); Same comment as before.. I kind of don't like having the first if block lead to a MOZ_CRASH :) ::: gfx/layers/d3d9/TextureD3D9.cpp @@ +25,5 @@ > uint32_t aTextureFlags) > { > RefPtr<DeprecatedTextureHost> result; > if (aDescriptorType == SurfaceDescriptor::TYCbCrImage) { > + MOZ_CRASH("Should be using non-deprecated textures"); Ditto. Though this one is even more complicated to untangle. Maybe just MOZ_ASSERT(aDescriptorType != TYCbCrImage) ?

Fixed that by removing YCbCrImage and RGBImage entirely form the surface descriptor types.

I uploaded and got this patch reviewed by vlad on the wrong bug (Bug 965804 which is closed) So I guess it's better that I land it with a bug that is still open. Sorry for the confusion.

Comment on attachment 8370002 [details] [diff] [review] Remove a lot of deprecated code Gah sorry, this got lost in my tracking.