Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Description • 10 years ago

I get this error whenever closing an e10s browser.

	Matthew N. [:MattN]
	Comment 1 • 10 years ago

Comment on attachment 8369656 [details] [diff] [review]
dom-identity-fix

Review of attachment 8369656 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/identity/DOMIdentity.jsm
@@ +221,5 @@
>      return this._serviceContexts.get(this._mmContexts.get(targetMM));
>    },
>  
> +  hasContextForMM: function(targetMM) {
> +    return this._mmContexts.has(targetMM);

I'm not sure we need a method for this one case when we can just assign the result of this.getContextForMM to a variable and then:
if (!context) {
  return;
}

	Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Comment 2 • 10 years ago

> I'm not sure we need a method for this one case when we can just assign the result of
> this.getContextForMM to a variable and then:
> if (!context) {
>   return;
> }

That will work, but I don't really like how it causes us to call this._serviceContexts.get(undefined). I could add an early exit to getContextForMM as well, I guess.

	Matthew N. [:MattN]
	Comment 3 • 10 years ago

Comment on attachment 8369656 [details] [diff] [review]
dom-identity-fix

Review of attachment 8369656 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, yeah, that's not very nice.

	Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Comment 4 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d8e85cda93d

	Jed Parsons (use needinfo, please) [:jedp, :jparsons]
	Comment 5 • 10 years ago

MattN, billm, thanks for jumping on this.

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/0d8e85cda93d

	Borja Salguero [:borjasalguero]
	Comment 9 • 10 years ago

Hi! Currently I'm working with Firefox Accounts and I can see this
"E/GeckoConsole(11246): [JavaScript Error: "this.getContextForMM(...).RP is undefined" {file: 
"resource://gre/modules/DOMIdentity.jsm" line: 362}]" again... 
This happens to me when closing the app after calling 'navigator.mozId.watch'.
Could you take a look? Thanks!

	Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Comment 10 • 10 years ago

I'm not sure what's going on. Please open a separate bug since the original problem was fixed. Also, please check that you're running a version of Gecko that has the bug fix. It looks like you're using b2g, so you may be using an old version of Gecko. This bug was fixed in version 30.