Closed
Bug 967297
Opened 11 years ago
Closed 11 years ago
Touching ipc/ipdl/ipdl/lower.py does not cause the IPDL files to be regenerated
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: ehsan.akhgari, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This could be one reason for clobbering.
Reporter | ||
Comment 1•11 years ago
|
||
Gregory, can you please fix this or tell me how to fix this? This will break the patch for bug 967167 when it gets checked in.
Blocks: ipc-big-arrays
Flags: needinfo?(gps)
Comment 2•11 years ago
|
||
We may have this on file already. The make dependency file for IPDL isn't pulling in imported .py files in addition to self.
Blocks: clobber
Flags: needinfo?(gps)
Assignee | ||
Comment 3•11 years ago
|
||
This is not the absolute best solution, but it fits in well with what we already have.
Attachment #8370179 -
Flags: review?(gps)
Reporter | ||
Comment 4•11 years ago
|
||
This is a gross hack. Why can't we just encode the dependency information in the build system instead?
Comment 5•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #4) > This is a gross hack. Why can't we just encode the dependency information > in the build system instead? Can you guarantee that dependency information won't get outdated?
Updated•11 years ago
|
Attachment #8370179 -
Flags: review?(gps) → review+
Comment 6•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #4) > This is a gross hack. Why can't we just encode the dependency information > in the build system instead? This is a similar approach we use elsewhere. Next step is to write out the Python dependencies into a .pp file somewhere so make won't invoke the IPDL processor if nothing has changed.
Reporter | ||
Comment 7•11 years ago
|
||
(In reply to comment #5) > (In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, > emailacopolypse) from comment #4) > > This is a gross hack. Why can't we just encode the dependency information > > in the build system instead? > > Can you guarantee that dependency information won't get outdated? I take it that this is a rhetorical question.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → nfroyd
Keywords: checkin-needed
Reporter | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9185c4a586df
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9185c4a586df
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•