Closed
Bug 967508
Opened 11 years ago
Closed 11 years ago
Write mochitests for services/fxaccounts
Categories
(Firefox :: Firefox Accounts, defect)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: ferjm, Assigned: jedp)
References
Details
In order to avoid regressions like bug 967503 we need to write some mochitests apart from the already existing xpcshell tests.
Reporter | ||
Updated•11 years ago
|
Component: User Story → FxA
Product: Tracking → Firefox
Version: --- → unspecified
Updated•11 years ago
|
Component: FxA → Firefox Sync: Backend
Product: Firefox → Mozilla Services
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jparsons
Assignee | ||
Comment 1•11 years ago
|
||
I'm working on this as part of Bug 943521.
Updated•11 years ago
|
Component: Firefox Sync: Backend → FxA
Product: Mozilla Services → Core
Updated•11 years ago
|
Assignee | ||
Comment 2•11 years ago
|
||
Some mochitests will land with Bug 945363 and Bug 963835.
Comment 3•11 years ago
|
||
Jed marking this nice to have per Fernando's suggestion in bug 974123 -- place in your list TBD.
Assignee | ||
Comment 4•11 years ago
|
||
That's fine. Mochitests are starting to trickle in with other patches, so we have a start. But tests should be written for each method.
Assignee | ||
Comment 5•11 years ago
|
||
In addition to those mentioned in Comment 2, more will arrive when we land bug 947374 and bug 971379.
So this is moving forward on other fronts :)
Assignee | ||
Comment 6•11 years ago
|
||
Hi, Fernando,
Over the past few weeks, we've grown a decent bunch of mochitests:
Bug 945363 has mochitests to ensure that RP callbacks fire in the correct sequence
Bug 947374 has mochitests for ensuring that only certified apps can declare a different assertion audience; the tests exercise watch/request for appStatuses 1, 2, and 3.
Bug 971379 has mochitests to ensure that only certified apps can call request() outside of a user event handler; it also has tests for appStatuses 1, 2, and
Bug 974990 has mochitests for accept-language headers
Bug 978896 adds more mochitests to test how watch() and request() behave when there is or is not already a signed-in user.
I feel like we've got a pretty solid basic coverage with those tests. Are there others that you think we ought to write?
Flags: needinfo?(ferjmoreno)
Reporter | ||
Comment 7•11 years ago
|
||
Thanks for adding all these tests Jed! This looks like a nice battery of tests, specially for the RP API.
It would also be great to have some marionette functional tests for B2G, do you know if there is any bug tracking this work?
Flags: needinfo?(ferjmoreno)
Comment 8•11 years ago
|
||
Fernando this is bug 989368 .
Comment 9•11 years ago
|
||
I will mark this Resolved/Fixed unless one of you feels otherwise. bug 989368 is a project dependency and should not get lose.
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → mozilla31
Updated•7 years ago
|
Product: Core → Firefox
Updated•7 years ago
|
Target Milestone: mozilla31 → Firefox 31
You need to log in
before you can comment on or make changes to this bug.
Description
•