Closed
Bug 967785
Opened 11 years ago
Closed 11 years ago
need TBD image for logged-out panel (and also FTE start panel)
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
(Whiteboard: [qa+])
Attachments
(4 files)
another one for jgruen. we definitely need something here, the grey square isn't quite right ;-)
Comment 1•11 years ago
|
||
This should just be the Firefox Logo. Do you need an asset for this?
Comment 2•11 years ago
|
||
Flat Fox:
https://www.dropbox.com/s/zwuk9bl74i46mog/Flat%20Fox%402x.png
https://www.dropbox.com/s/ov087dvunxg1u8g/Flat%20Fox.png
LMK if we need different sizes or colors
Assignee | ||
Updated•11 years ago
|
Comment 3•11 years ago
|
||
foxes in here: https://www.dropbox.com/sh/falu4kt9w22cy4r/My_T8XvxYi
Assignee | ||
Comment 4•11 years ago
|
||
Hi reviewers,
Do you have time for a quick review?
This is a very simple fix (replacing a TBD image with a final image), but it spans three apps. Trying to minimize paperwork by putting all three changes in one PR.
Thanks very much!
Jared
Attachment #8411284 -
Flags: review?(francisco.jordano)
Attachment #8411284 -
Flags: review?(ferjmoreno)
Attachment #8411284 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 5•11 years ago
|
||
I should also add that I've separated the three commits that touch each of the separate apps, to make reviewing simpler for each of you.
Thanks again :-)
Assignee | ||
Comment 7•11 years ago
|
||
Two more things:
1. To make it clear how things were changing, I've added before and after screenshots of each of the affected screens as comments in the github pull request.
2. I also needed to update an envelope icon in the settings and system apps. I've added those commits to the existing PR, along with before/after screenshots for those changes, too.
Comment 8•11 years ago
|
||
Comment on attachment 8411284 [details]
Github PR 18608
Please, run the images through the png_recompress.sh script.
https://github.com/mozilla-b2g/gaia/blob/master/tools/png_recompress.sh
Attachment #8411284 -
Flags: review?(ferjmoreno)
Comment 9•11 years ago
|
||
Comment on attachment 8411284 [details]
Github PR 18608
r+ for the FTU, once you run the script for compressing the images as Fernando comments.
Thanks!
Attachment #8411284 -
Flags: review?(francisco.jordano) → review+
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #8)
> Comment on attachment 8411284 [details]
> Github PR 18608
>
> Please, run the images through the png_recompress.sh script.
>
> https://github.com/mozilla-b2g/gaia/blob/master/tools/png_recompress.sh
Thanks! I didn't realize that was even a thing.
Assignee | ||
Updated•11 years ago
|
Attachment #8411284 -
Flags: review?(ferjmoreno)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Francisco Jordano [:arcturus] from comment #9)
> Comment on attachment 8411284 [details]
> Github PR 18608
>
> r+ for the FTU, once you run the script for compressing the images as
> Fernando comments.
>
> Thanks!
Awesome! Thanks Francisco.
Comment 12•11 years ago
|
||
Comment on attachment 8411284 [details]
Github PR 18608
Thanks Jared!
Attachment #8411284 -
Flags: review?(ferjmoreno) → review+
Comment 13•11 years ago
|
||
Jared, could you request a ui review ensuring this is as expected? And please also flag the owner of the system app for review. Thanks.
Assignee | ||
Comment 14•11 years ago
|
||
Hi Arthur - That's odd, are you using the emulator to generate that screenshot? I included a lot of screenshots in the github PR, the hamachi looked fine there[1]. I also reflashed my hamachi with today's master, and the screen looks correct for me still (see this attachment).
What build of gaia/gecko are you using on your device/emulator?
Fernando is a system peer and has given r+, I think we're good there?
[1] https://github.com/mozilla-b2g/gaia/pull/18608#issuecomment-41235020
Flags: needinfo?(arthur.chen)
Comment 15•11 years ago
|
||
Comment on attachment 8411284 [details]
Github PR 18608
Oh, I guess I tweaked the class name to see all the pages. My screenshot seems wrong as it does not have the email address and which leads to the incorrect layout. r=me, thanks for the patch!
Attachment #8411284 -
Flags: review?(arthur.chen) → review+
Flags: needinfo?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Assignee: jgruen → 6a68
Assignee | ||
Comment 16•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v2.0:
--- → fixed
QA Contact: npark
Resolution: --- → FIXED
Whiteboard: [qa+]
Target Milestone: --- → 2.0 S1 (9may)
You need to log in
before you can comment on or make changes to this bug.
Description
•