Closed
Bug 967824
Opened 11 years ago
Closed 11 years ago
Faulty assert failure: "called SetCompositableHost for a layer without a compositable host" under LayerTransactionParent::RecvUpdate
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: bjacob, Assigned: bjacob)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
Found by Christoph Diehl's "Faulty" fuzzer, see bug 777067
|
Assignee | |
Comment 1•11 years ago
|
||
Not obvious to me how we get here. This LayerComposite is of a type that doesn't override the virtual SetCompositableHost method, and this code expect that it does.
Classification: PLayerTransaction, confused about layer types, hard
|
|
Assignee | |
Updated•11 years ago
|
Depends on: PReinterpretCast
|
|
Assignee | |
Comment 2•11 years ago
|
||
In RecvUpdate in the TOpAttachAsyncCompositable case we are assuming that the layer is of a certain type, and we shouldn't. That is why the fix for bug 968833 is not enough by itself to fix this bug (it still reproduces with the patch applied).
|
|
Assignee | |
Comment 3•11 years ago
|
||
This makes SetCompositable graceful i.e. returning false and warning instead of aborting debug builds.
Attachment #8373754 -
Flags: review?(nical.bugzilla)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Also note the comment edit, as it was refering to "a compositable host" in separate words, which suggests that its author himself got confused about the Host-as-a-suffix terminology.
|
||
Updated•11 years ago
|
Attachment #8373754 -
Flags: review?(nical.bugzilla) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Assignee: nobody → bjacob
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•