Closed Bug 967857 Opened 11 years ago Closed 11 years ago

[B2G][l10n][Gaia][Keyboard] Bengali: The Probhat keyboard for the Bengali language includes symbols that do not fit in the keyboard button.

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

RESOLVED FIXED
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: lmauritson, Assigned: rudyl)

References

Details

(Keywords: l12y, Whiteboard: LocRun1.3)

Attachments

(3 files, 3 obsolete files)

Attached image bengali_kb.png (deleted) —
Description: The Probhat keyboard for the Bengali language has buttons that are too small, or symbols that are too big, for some of the buttons. (See attached) Repro Steps: 1) Update a Buri to BuildID: 20140203181708 2) Set the keyboard to Bengali - Probhat 3) Enter an app where the text can be edited and select the text box 4) Observe the keys and how they fit inside the keyboard button graphics (Especially on the lower right) Actual: Some of the buttons are not large enough for the symbols drawn inside them. (See pic) Expected: All symbols fit nicely inside the keyboard buttons. 1.3 Environmental Variables: Device: Buri 1.3 MOZ BuildID: 20140203181708 Gaia: 0388dcb7621c5933712680a258ce94ead389e2b6 Gecko: 9731b0b7fa78 Version: 28.0 Firmware Version: v1.2-device.cfg Repro frequency: 100% See attached: Screenshot
We can do a similar thing as with Arabic. Where we have: https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/ar.js#L5 See the code in bug 897362. I'd really like this in 1.3 due to partner release.
Assignee: nobody → janjongboom
Hi Lionel, how did you get into this state. Is this the default one or is it based on context? Because this is what I see.
Flags: needinfo?(lmauritson)
blocking-b2g: --- → 1.3?
blocking-b2g: 1.3? → 1.3+
The keyboard shown was the one I had as default. It certainly doesn't look as clean as the one in comment 2. On top of the 1.3 build above we used an engineering build to get all the keyboards. We pulled the build by: git clone -b v1.3 https://github.com/mozilla-b2g/gaia.git Then ran git pull To update to the latest v1.3 and ran the GAIA_KEYBOARD_LAYOUTS=en,es,it,cs,hu,nl,ru,sk,de,bn-Avro,bn-Probhat,bg-BDS,ca make reset-gaia To build the Gaia
Flags: needinfo?(lmauritson)
Has there been any visual update between v1.3 and master? If so we should just cherry-pick that to v1.3.
Jan, are you actively looking at this? This seems only affected 1.3.
Flags: needinfo?(janjongboom)
Yeah I'm looking at it.
Flags: needinfo?(janjongboom)
Attached file Patch for v1.3 (obsolete) (deleted) —
This is a patch for 1.3: Backporting bug 897362 and adding custom rules for Bangla Probhat.
Attachment #8371319 - Flags: review?(rlu)
Attached file Patch for master (obsolete) (deleted) —
Attachment #8371323 - Flags: review?(rlu)
Comment on attachment 8371319 [details] Patch for v1.3 Jan, Wouldn't the font too small for other characters? Is it possible that we could only adjust the font size for the characters that were truncated? Thanks.
Attachment #8371319 - Flags: review?(rlu)
Maybe, but it would look pretty inconsistent to have some keys smaller... I'll try some stuff tomorrow.
Stealing this bug since it is a blocker. Will send the patch immediately.
Assignee: janjongboom → rlu
Attached file Patch V1 - (obsolete) (deleted) —
Attached file Patch V1 - pull request 16116 (deleted) —
Adding specific CSS rules for the UI truncation issue. Tim, Could you please help review this CSS-only patch? Thhanks.
Attachment #8373167 - Flags: review?(timdream)
Attachment #8373162 - Attachment is obsolete: true
Comment on attachment 8373167 [details] Patch V1 - pull request 16116 It's probably better if we could provide a general fix in the future.
Attachment #8373167 - Flags: review?(timdream) → review+
Rudy, thank you for jumping in, by the way.
Attachment #8371323 - Flags: review?(rlu)
Attachment #8371319 - Attachment is obsolete: true
Attachment #8371323 - Attachment is obsolete: true
Blocks: 949609
As being a native speaker of Bengali_Bangladesh, I like and support the appearance, I saw in the attachment of Comment 2.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: