Closed
Bug 967857
Opened 11 years ago
Closed 11 years ago
[B2G][l10n][Gaia][Keyboard] Bengali: The Probhat keyboard for the Bengali language includes symbols that do not fit in the keyboard button.
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)
RESOLVED
FIXED
blocking-b2g | 1.3+ |
People
(Reporter: lmauritson, Assigned: rudyl)
References
Details
(Keywords: l12y, Whiteboard: LocRun1.3)
Attachments
(3 files, 3 obsolete files)
Description:
The Probhat keyboard for the Bengali language has buttons that are too small, or symbols that are too big, for some of the buttons. (See attached)
Repro Steps:
1) Update a Buri to BuildID: 20140203181708
2) Set the keyboard to Bengali - Probhat
3) Enter an app where the text can be edited and select the text box
4) Observe the keys and how they fit inside the keyboard button graphics (Especially on the lower right)
Actual:
Some of the buttons are not large enough for the symbols drawn inside them. (See pic)
Expected:
All symbols fit nicely inside the keyboard buttons.
1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140203181708
Gaia: 0388dcb7621c5933712680a258ce94ead389e2b6
Gecko: 9731b0b7fa78
Version: 28.0
Firmware Version: v1.2-device.cfg
Repro frequency: 100%
See attached: Screenshot
Comment 1•11 years ago
|
||
We can do a similar thing as with Arabic. Where we have: https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/ar.js#L5
See the code in bug 897362.
I'd really like this in 1.3 due to partner release.
Updated•11 years ago
|
Assignee: nobody → janjongboom
Comment 2•11 years ago
|
||
Hi Lionel, how did you get into this state. Is this the default one or is it based on context? Because this is what I see.
Flags: needinfo?(lmauritson)
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Updated•11 years ago
|
blocking-b2g: 1.3? → 1.3+
Reporter | ||
Comment 3•11 years ago
|
||
The keyboard shown was the one I had as default. It certainly doesn't look as clean as the one in comment 2.
On top of the 1.3 build above we used an engineering build to get all the keyboards.
We pulled the build by:
git clone -b v1.3 https://github.com/mozilla-b2g/gaia.git
Then ran
git pull
To update to the latest v1.3
and ran the
GAIA_KEYBOARD_LAYOUTS=en,es,it,cs,hu,nl,ru,sk,de,bn-Avro,bn-Probhat,bg-BDS,ca make reset-gaia
To build the Gaia
Flags: needinfo?(lmauritson)
Comment 4•11 years ago
|
||
Has there been any visual update between v1.3 and master? If so we should just cherry-pick that to v1.3.
Comment 5•11 years ago
|
||
Jan, are you actively looking at this? This seems only affected 1.3.
status-b2g-v1.4:
--- → unaffected
Flags: needinfo?(janjongboom)
Comment 7•11 years ago
|
||
This is a patch for 1.3:
Backporting bug 897362 and adding custom rules for Bangla Probhat.
Attachment #8371319 -
Flags: review?(rlu)
Comment 8•11 years ago
|
||
Attachment #8371323 -
Flags: review?(rlu)
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 8371319 [details]
Patch for v1.3
Jan,
Wouldn't the font too small for other characters?
Is it possible that we could only adjust the font size for the characters that were truncated?
Thanks.
Attachment #8371319 -
Flags: review?(rlu)
Comment 10•11 years ago
|
||
Maybe, but it would look pretty inconsistent to have some keys smaller... I'll try some stuff tomorrow.
Assignee | ||
Comment 11•11 years ago
|
||
Stealing this bug since it is a blocker.
Will send the patch immediately.
Assignee: janjongboom → rlu
Assignee | ||
Comment 12•11 years ago
|
||
Assignee | ||
Comment 13•11 years ago
|
||
Adding specific CSS rules for the UI truncation issue.
Tim,
Could you please help review this CSS-only patch?
Thhanks.
Attachment #8373167 -
Flags: review?(timdream)
Assignee | ||
Updated•11 years ago
|
Attachment #8373162 -
Attachment is obsolete: true
Comment 14•11 years ago
|
||
Comment on attachment 8373167 [details]
Patch V1 - pull request 16116
It's probably better if we could provide a general fix in the future.
Attachment #8373167 -
Flags: review?(timdream) → review+
Comment 15•11 years ago
|
||
Rudy, thank you for jumping in, by the way.
Assignee | ||
Comment 16•11 years ago
|
||
Gaia master,
https://github.com/mozilla-b2g/gaia/commit/31af75189710e8930be943dc96a4ccd339a6010f
v1.3,
https://github.com/mozilla-b2g/gaia/commit/5c8416fb1ea4a27f172ee6386ab3c19135448506
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Attachment #8371323 -
Flags: review?(rlu)
Assignee | ||
Updated•11 years ago
|
Attachment #8371319 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #8371323 -
Attachment is obsolete: true
Comment 17•11 years ago
|
||
As being a native speaker of Bengali_Bangladesh, I like and support the appearance, I saw in the attachment of Comment 2.
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•