Closed Bug 967878 Opened 11 years ago Closed 11 years ago

[Messages] Background doesn't scroll with the threads causing expensive over-invalidation

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Type:
defect

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S1 (14feb)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Keywords: perf, Whiteboard: [c=handeye p= s=2014.02.14 u=1.3] [ETA=2/7])

Attachments

(1 file)

bug967878.patch
(deleted), patch
julienw
: review+
BenWa
: review+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #967274 +++ This is the same issue as bug 950250 but for the Messages app. See that bug for more details
Assignee: nobody → 21
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 8370385 [details] [diff] [review] bug967878.patch Benoit I think I understood what you were looking for but I'm asking r? just to make sure.
Attachment #8370385 - Flags: review?(bgirard)
Attachment #8370385 - Flags: review?(bgirard) → review+
Interesting—this seems like a platform issue.
(In reply to Rick Waldron [:rwaldron] from comment #3) > Interesting—this seems like a platform issue. It's because of how CSS is spec'ed. GFX/layout folks are thinking of doing an optimization in the platform but it is too short for 1.3.
I guess this is a 1.3 blocker. This is also a very safe patch.
blocking-b2g: --- → 1.3+
Comment on attachment 8370385 [details] [diff] [review] bug967878.patch Review of attachment 8370385 [details] [diff] [review]: ----------------------------------------------------------------- I'm not saying I understand everything, but well, I do see the effect. ::: apps/sms/style/sms.css @@ +123,4 @@ > } > > #threads-container[data-type="list"] ul { > + background-color: white; I think we need a small comment explaining why we're adding this, with either a gecko bug # if you have it, or this bug #
Attachment #8370385 - Flags: review?(felash) → review+
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [c=handeye 1=2 s= u=][ETA=2/7]
Whiteboard: [c=handeye 1=2 s= u=][ETA=2/7] → [c=handeye p=2 s= u=1.3][ETA=2/7]
Whiteboard: [c=handeye p=2 s= u=1.3][ETA=2/7] → [c=handeye p=2 s=2014.02.14 u=1.3] [ETA=2/7]
Target Milestone: --- → 1.4 S1 (14feb)
Whiteboard: [c=handeye p=2 s=2014.02.14 u=1.3] [ETA=2/7] → [c=handeye p= s=2014.02.14 u=1.3] [ETA=2/7]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: