This patch adds basic support for Metro to handle the PluginBindingAttached event, which is fired when a click-to-play plugin overlay is added to a document. For more details, see attachment 653108 [details]. This is required for extensions like Shumway and PDF.js to replace plugins in content. It also provides some hooks we could use to provide messages to the user about unsupported plugins (bug 936907).

Hey Matt, are you taking this bug during this iteration?

(In reply to Marco Mucci [:MarcoM] from comment #1) > Hey Matt, are you taking this bug during this iteration? Sure, why not.

This is the minimal PluginBindingAttached handler needed to get Shumway working in Metro Firefox. As you can see from the patch, it's directly copied from the Android version, with all of the code removed except for the "playPreview" parts used by Shumway and similar extensions. (You may need to look at the raw attachment, since Splinter doesn't always work well with "hg cp".) With this patch applied, you can set shumway.disabled=false in about:config to use Shumway to handle embedded Flash content on web pages.

Comment on attachment 8379909 [details] [diff] [review] patch Review of attachment 8379909 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.

For testing and verification. Reopen if any defects found.

While merging inbound to m-c after I merged this patch from fx-team to m-c, I had conflicts from part of one of John's patches in https://hg.mozilla.org/integration/mozilla-inbound/diff/b6a4f6e8ef8c/mobile/android/chrome/content/PluginHelper.js that I hopefully resolved correctly: https://hg.mozilla.org/mozilla-central/diff/626d99c084cb/browser/metro/base/content/contenthandlers/PluginHelper.js

(In reply to Wes Kocher (:KWierso) from comment #8) > While merging inbound to m-c after I merged this patch from fx-team to m-c, > I had conflicts from part of one of John's patches in > https://hg.mozilla.org/integration/mozilla-inbound/diff/b6a4f6e8ef8c/mobile/ > android/chrome/content/PluginHelper.js that I hopefully resolved correctly: > > https://hg.mozilla.org/mozilla-central/diff/626d99c084cb/browser/metro/base/ > content/contenthandlers/PluginHelper.js The merge looks right to me. For the record, the conflict was this bug changing HTMLAppletElement to plugin.ownerDocument.defaultView.HTMLAppletElement, whereas my patch removed that line entirely. The merge properly keeps the line deleted.

Went through the verification process using the following build: - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-03-03-02-01-mozilla-central/ Shumway Test Cases: - Ensured that HTML5 video(s) still played while Shumway has been enabled (YouTube, Dailymotion) - Ensured that HTML5 video(s) using the Kaltura video platform are working correctly while Shumway has been enabled - Visited several flash websites with Shumway enabled and ensured that there's no crashes nor any stability issues - Loaded several animated headers and ensured that they loaded without any issues when Shumway has been enabled - Ensured that flash related items are not being loaded when Shumway has been disabled through about:config - Went through several of the Shumway demo's without any issues (they did however slow down the performance of the browser) - Went through all of the above test cases with several different variations of snapped view PDF.js Test Cases: - Opened several PDF(s) with PDF.js enabled - Used the different controls under PDF.js - Ensured that PDF's are opened using the correct default application if PDF.js has been disabled - Went through all of the above test cases using different variations of snapped view Found the following issues when going through the verification process: - Created Bug #978848 - fxmetro becomes very slow when running multiple flash websites using Shumway Went through the issue using the following hardware: - X1 Carbon - Surface Pro 2