Closed Bug 96817 Opened 23 years ago Closed 23 years ago

Menu item spacing is larger for Bookmarks Menu

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
Windows 98
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.6

People

(Reporter: doctor__j, Assigned: shliang)

References

Details

Attachments

(4 files)

From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3+) Gecko/20010823 BuildID: 2001082306 Summary says it all. See screenshot for comparison with other menu.
Attached image Screenshot fot comparison (deleted) —
Summary: Item menu spacing is larger for Bookmarks Menu → Menu item spacing is larger for Bookmarks Menu
*** Bug 96578 has been marked as a duplicate of this bug. ***
*** Bug 97885 has been marked as a duplicate of this bug. ***
I'm seeing this on Linux and Windows 2000 as well. This bug was introduced sometime between 0.9.3 and 0.9.4.
Not present (or not really noticeable) in the Classic skin. I suspect this is because the graphics are a touch too big for the default text size. Gerv
This was probably caused by blake's checking for bookmark folder drag and drop. He added some transparent borders which turn black to indicate a dnd insertion point. Should be trivial to fix.
Assignee: ben → hewitt
It isn't on Classic at all from what I can tell. I reported a dupe of this. Seemed to show up maybe a month/5 weeks ago, at a guess. If it's the invis borders just taking up too much room, it should be easy, yeah. The trick is knowing where to look for them in the code. :)
You can see the date around it did happened in general or seamonkey newsgroup. I wrote there arond it began to happen. It should be a message from Eugene Savitsky (ezh@infonet.ee).
Mass reassigning my theme bugs to Shuehan.
Assignee: hewitt → shliang
Attached patch patch (deleted) — Splinter Review
Keywords: patch, review
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.6
Comment on attachment 51791 [details] [diff] [review] patch sr=hewitt
Attachment #51791 - Flags: superreview+
Comment on attachment 51791 [details] [diff] [review] patch r=andreww
Attachment #51791 - Flags: review+
Blocks: 105174
Attached patch doing this over (deleted) — Splinter Review
Any hope for 0.9.6?
Yes, this is because of what hewitt said. Why are we 'fixing' this? It's the same way in IE, and this is how it really should be for now...
The fix we're looking for is just to make them a bit smaller, not to get rid of them. Since Classic doesn't have this problem, why should it be present in Modern?
I agree with Grey. Besides, what's the same way in IE? I just checked and IE doesn't have too much space between bookmark(favorite) menu items, unlike Mozilla with the Modern theme.
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified using 2001110203 on Win2K. Also confirmed that the lines still show up when dragging a bookmark around in the Bookmarks menu on the Personal Toolbar.
Status: RESOLVED → VERIFIED
Beautiful. We all thank you and your sons for seven generations. ;)
There's still a small issue with the width of bookmarks and folders on the personal toolbar. See the screenshot for comparison between Modern and Classic. (You can also see the difference, for example, between NS 6.1 and 6.2 using the Modern theme.) I don't know if this should be a separate bug, or if it's intentional perhaps...
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: