security/certverifier is nearly warning-free, aside from one warning (bug 962693 comment 10) that I think Camilo is posting a patch to suppress with #ifdefs soon. One that patch is in, we can mark this directory as FAIL_ON_WARNINGS. Proof: https://tbpl.mozilla.org/?tree=Try&rev=4b402b646287 (That Try run includes a s/static/inline/ hack to disable the aforementioned warning from bug 962693)

(In reply to Daniel Holbert [:dholbert] from comment #0) > (That Try run includes a s/static/inline/ hack to disable the aforementioned > warning from bug 962693) (er, correction: looks like I actually hacked around it in that Try run by commenting out the function)

Comment on attachment 8371070 [details] [diff] [review] fix Review of attachment 8371070 [details] [diff] [review]: ----------------------------------------------------------------- NIT: please use r=briansmith in the commit message. Thanks for this, and thanks for clarifying how FAIL_ON_WARNINGS works.

Will do. Thanks!

Comment on attachment 8371093 [details] [diff] [review] add-ifdef-to-allow-warning-free-compile per IRL conversation with cviecco: I'll land this with rs=me (to fix the build warning), on the understanding that this code won't remain #ifdeffed out for too long.

Comment on attachment 8371093 [details] [diff] [review] add-ifdef-to-allow-warning-free-compile Review of attachment 8371093 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.

or better, I'll land it with r=briansmith :)

Sanity-check Try run, with these patches and a few others: https://tbpl.mozilla.org/?tree=Try&rev=b19e92decdb9

(The build error in that Try run is from bug 968323's patch being not-quite-complete. I'll fix & re-Try, and then push if all is well.)

New Try run with that fixed: https://tbpl.mozilla.org/?tree=Try&rev=3b48dd15290d

Landed Camilo's helper-patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/98236f59f6f9 and the FAIL_ON_WARNINGS patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/b0854f873c68

https://hg.mozilla.org/mozilla-central/rev/98236f59f6f9 https://hg.mozilla.org/mozilla-central/rev/b0854f873c68