Mike Hommey [:glandium] Assignee
	Description • 11 years ago

To help with the incremental merge of the js/src build system with toplevel, js's configure needs not to run make, which it currently does to create js-config.

	Mike Hommey [:glandium] Assignee
	Comment 1 • 11 years ago

Note this does change the ldflags exposed by both js-config and js.pc, but also note that the current values they expose are currently completely wrong (like, they include -Wl,--version-script)

	(not currently active) Ted Mielczarek
	Comment 2 • 11 years ago

Comment on attachment 8371125 [details] [diff] [review]
Build js-config from configure instead of Makefile

Review of attachment 8371125 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +291,4 @@
>  SCRIPTS = $(JS_CONFIG_NAME)
>  SDK_BINARY = $(JS_CONFIG_NAME)
>  
> +$(LIBRARY_NAME).pc: js.pc

Can we just output these both during configure?

	Mike Hommey [:glandium] Assignee
	Comment 3 • 11 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> > +$(LIBRARY_NAME).pc: js.pc
> 
> Can we just output these both during configure?

We don't have stuff to say "create this file from that other .in file" yet. And I (obviously) don't want to add a Preprocessor command in configure itself. I think we'll eventually want something for "create this file from that other .in file" things, so let's just wait for that.

	Mike Hommey [:glandium] Assignee
	Comment 4 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9468c7f9fe8d

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/9468c7f9fe8d