Closed
Bug 968684
Opened 11 years ago
Closed 11 years ago
Add Makefile for homescreen app
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: yurenju)
References
Details
Attachments
(1 file)
add a makefile for homescreen and migrate homescreen related code from applications-data.js and webapp-zip.js
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → yurenju.mozilla
Assignee | ||
Comment 1•11 years ago
|
||
WIP: https://github.com/yurenju/gaia/commit/5ec4388b68da31519175f1a69bf0daea46dd7365
since homescreen use webapp-manifests.js to get all manifests of apps, I'm going to refactor communications app first because comm. app use webapp-manifests.js to get their own manifest file.
Assignee | ||
Comment 2•11 years ago
|
||
high resolution icon doesn't apply to homescreen when first launch, we should fix it for build script part.
Assignee | ||
Comment 3•11 years ago
|
||
last one for app-makefile refactoring!
I also filed a follow up bug 972755 to store preload apps data from DISTRIBUTION_DIR/temp to build_stage/preload-app-data/.
Attachment #8376114 -
Flags: review?(timdream)
Comment 4•11 years ago
|
||
Comment on attachment 8376114 [details]
github PR: https://github.com/mozilla-b2g/gaia/pull/16283
Discussed offline.
Damn you svoperapps!
Attachment #8376114 -
Flags: review?(timdream)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8376114 [details]
github PR: https://github.com/mozilla-b2g/gaia/pull/16283
refactored this refactoring code \o/
I commited for each your comment on github, those will be squashed to one commit if get r+
Attachment #8376114 -
Flags: review?(timdream)
Comment 6•11 years ago
|
||
Comment on attachment 8376114 [details]
github PR: https://github.com/mozilla-b2g/gaia/pull/16283
Please manually confirm both old script and new script passes the test, before merging the pull request.
Thank you, nice work!
Attachment #8376114 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 7•11 years ago
|
||
waiting for travis-ci.
Assignee | ||
Comment 8•11 years ago
|
||
travis-ci: https://travis-ci.org/mozilla-b2g/gaia/builds/19100087
merged.
https://github.com/mozilla-b2g/gaia/commit/b85725cac0fc0f76fef2366055c3e55834f261d0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Component: Gaia → Gaia::Build
You need to log in
before you can comment on or make changes to this bug.
Description
•