https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c8ca9dbaf6 https://hg.mozilla.org/integration/mozilla-inbound/rev/ee7682771589 https://hg.mozilla.org/integration/mozilla-inbound/rev/b781793ab79f https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a6f6fb6db3 https://hg.mozilla.org/integration/mozilla-inbound/rev/11cb08d1670c https://hg.mozilla.org/integration/mozilla-inbound/rev/f0a563b325eb https://hg.mozilla.org/integration/mozilla-inbound/rev/c160e03f2a4f

https://hg.mozilla.org/mozilla-central/rev/f5c8ca9dbaf6 https://hg.mozilla.org/mozilla-central/rev/ee7682771589 https://hg.mozilla.org/mozilla-central/rev/b781793ab79f https://hg.mozilla.org/mozilla-central/rev/e5a6f6fb6db3 https://hg.mozilla.org/mozilla-central/rev/11cb08d1670c https://hg.mozilla.org/mozilla-central/rev/f0a563b325eb https://hg.mozilla.org/mozilla-central/rev/c160e03f2a4f

Comment on attachment 8371489 [details] [diff] [review] Part k: GetScrollXY Review of attachment 8371489 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsGlobalWindow.h @@ +1195,5 @@ > > // If aDoFlush is true, we'll flush our own layout; otherwise we'll try to > // just flush our parent and only flush ourselves if we think we need to. > + // Outer windows only. > + mozilla::CSSIntPoint GetScrollXY(bool aDoFlush); I would say rename this to ScrollXY, but it seems odd to have a getter with a verb for a name :/

Comment on attachment 8391721 [details] [diff] [review] Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an assertion part Review of attachment 8391721 [details] [diff] [review]: ----------------------------------------------------------------- You ought to be able to assert that the XPCOM version of GetFullScreen is only ever called on an outer, no?

(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #25) > Comment on attachment 8391721 [details] [diff] [review] > Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an > assertion part > > Review of attachment 8391721 [details] [diff] [review]: > ----------------------------------------------------------------- > > You ought to be able to assert that the XPCOM version of GetFullScreen is > only ever called on an outer, no? Maybe, but I'm not comfortable doing that.

https://hg.mozilla.org/integration/mozilla-inbound/rev/287f17ee7052 https://hg.mozilla.org/integration/mozilla-inbound/rev/be27b3a36983 https://hg.mozilla.org/integration/mozilla-inbound/rev/473ab7b769a0 https://hg.mozilla.org/integration/mozilla-inbound/rev/947fa1643644 https://hg.mozilla.org/integration/mozilla-inbound/rev/770ebe23e2f5 https://hg.mozilla.org/integration/mozilla-inbound/rev/26c2f6a41e3f https://hg.mozilla.org/integration/mozilla-inbound/rev/e6537268dd26 https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3722558673 https://hg.mozilla.org/integration/mozilla-inbound/rev/47514dfbd8d6 https://hg.mozilla.org/integration/mozilla-inbound/rev/f62480eb6d84 https://hg.mozilla.org/integration/mozilla-inbound/rev/ef9e5ce247d7 https://hg.mozilla.org/integration/mozilla-inbound/rev/c64a19d996cb https://hg.mozilla.org/integration/mozilla-inbound/rev/2cac985638c2 https://hg.mozilla.org/integration/mozilla-inbound/rev/48ad95c9ad89

https://hg.mozilla.org/mozilla-central/rev/287f17ee7052 https://hg.mozilla.org/mozilla-central/rev/be27b3a36983 https://hg.mozilla.org/mozilla-central/rev/473ab7b769a0 https://hg.mozilla.org/mozilla-central/rev/947fa1643644 https://hg.mozilla.org/mozilla-central/rev/770ebe23e2f5 https://hg.mozilla.org/mozilla-central/rev/26c2f6a41e3f https://hg.mozilla.org/mozilla-central/rev/e6537268dd26 https://hg.mozilla.org/mozilla-central/rev/ca3722558673 https://hg.mozilla.org/mozilla-central/rev/47514dfbd8d6 https://hg.mozilla.org/mozilla-central/rev/f62480eb6d84 https://hg.mozilla.org/mozilla-central/rev/ef9e5ce247d7 https://hg.mozilla.org/mozilla-central/rev/c64a19d996cb https://hg.mozilla.org/mozilla-central/rev/2cac985638c2 https://hg.mozilla.org/mozilla-central/rev/48ad95c9ad89