Closed
Bug 969744
Opened 11 years ago
Closed 7 years ago
Better support for install manifests
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: gps, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
feedback-
|
Details | Diff | Splinter Review |
I made some improvements to install manifests in bug 924187. Splitting out that change to make review easier.
Reporter | ||
Comment 1•11 years ago
|
||
Add an API that makes dynamically adding files to the objdir easier.
Add a manifest for dist/xpi-stage.
Attachment #8372728 -
Flags: review?(mh+mozilla)
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 8372728 [details] [diff] [review]
Make install manifests easier to use
Review of attachment 8372728 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Gregory Szorc [:gps] from comment #0)
> I made some improvements to install manifests in bug 924187. Splitting out
> that change to make review easier.
This actually doesn't make review easier, because it's not clear what the intent is, especially the consume change. Also, you're adding a manifest for dist_xpi-stage with nothing in it.
::: python/mozbuild/mozbuild/backend/recursivemake.py
@@ +1244,5 @@
> + 'dist/private': 'dist_private',
> + 'dist/sdk': 'dist_sdk',
> + 'dist/xpi-stage': 'dist_xpi-stage',
> + '_tests': 'tests',
> + 'config/makefiles/xpidl': 'xpidl',
seems to me we should have a "rule" to generate that mapping, because relying on this being updated whenever we add a manifest is error prone. And then rename the existing manifests accordingly.
That could be something as simple as .lower().subst('/','_')
@@ +1248,5 @@
> + 'config/makefiles/xpidl': 'xpidl',
> + }
> +
> + for prefix, key in mapping.items():
> + if path.startswith(prefix):
dist/binary would match dist/bin.
And we have mozpath.basedir which does this correctly :)
Attachment #8372728 -
Flags: review?(mh+mozilla) → feedback-
Reporter | ||
Updated•10 years ago
|
Assignee: gps → nobody
Status: ASSIGNED → NEW
Reporter | ||
Comment 3•7 years ago
|
||
This is an old clean-up bug. The patch has likely been bit rotted. I don't think there's any actions here.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•