This tracks not building or installing fennec_ids.txt in mobile/android/base; not uploading it during packaging; removing the generation script; and not pushing it to device in runtestsremote.py. There might be more!

See also prerequisite mozharness patch and additional notes from Bug 969926. gbrown: not sure if you or jmaher are the correct person for this, but I'd like you both to be aware of these changes.

Comment on attachment 8484367 [details] [diff] [review] Remove fennec_ids.txt from build system. r=jmaher Review of attachment 8484367 [details] [diff] [review]: ----------------------------------------------------------------- no red flags here- I am concerned that talos might fail if you do this. r=me if you run this on try and do talos tests which don't fail because of this.

Comment on attachment 8484367 [details] [diff] [review] Remove fennec_ids.txt from build system. r=jmaher Review of attachment 8484367 [details] [diff] [review]: ----------------------------------------------------------------- This all looks good. Be on the lookout for unforeseen breakage -- try or maybe a trial on the ash tree is probably essential.

Bug 969925 - Generate an empty fennec_ids.txt. r?gbrown Automation and some third-party tooling expects fennec_ids.txt, but an empty file should suffice.

gbrown: the back-story here is that I had r+ for removing more and then discovered dependencies in automation. This does less, but works around a problem sebastien and I witneseed in Bug 1171288. Let's see what try says!

Comment on attachment 8622598 [details] MozReview Request: Bug 969925 - Generate an empty fennec_ids.txt. r?gbrown Bug 969925 - Generate an empty fennec_ids.txt. r?gbrown Automation and some third-party tooling expects fennec_ids.txt, but an empty file should suffice.

Comment on attachment 8622598 [details] MozReview Request: Bug 969925 - Generate an empty fennec_ids.txt. r?gbrown https://reviewboard.mozilla.org/r/11419/#review9785

leave-open since there's more we should do for this ticket.

can you refresh my mind on how robocop will work? I am mostly concerned about talos.

We previously used fennec_ids.txt in FennecNativeDriver/FennecNativeElement, but that changed with bug 969926, primarily http://hg.mozilla.org/mozilla-central/rev/d3e11d7ae99d. I think we are free of fennec_ids.txt now!

(In reply to Geoff Brown [:gbrown] from comment #12) > We previously used fennec_ids.txt in FennecNativeDriver/FennecNativeElement, > but that changed with bug 969926, primarily > http://hg.mozilla.org/mozilla-central/rev/d3e11d7ae99d. I think we are free > of fennec_ids.txt now! Correct. We have no need for fennec_ids.txt /in tree/; we pass it around (using --robocop-ids and friends) still, but we shouldn't. What we still have is automation looking for it, and some external consumers using it as a marker of some sort.

The only consumers are in ash-mozharness, which is just out of date: http://mxr.mozilla.org/build/search?string=fennec_ids&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build Review commit: https://reviewboard.mozilla.org/r/42329/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42329/

Comment on attachment 8734521 [details] MozReview Request: Bug 969925 - Remove fennec_ids.txt from the build system. r?gbrown https://reviewboard.mozilla.org/r/42329/#review38867

https://hg.mozilla.org/integration/fx-team/rev/5c5e48022d8330131f67902bccc3c39737d2a93d Bug 969925 - Remove fennec_ids.txt from the build system. r=gbrown

why is this left open? do we have additional work to do here?

(In reply to Joel Maher (:jmaher) from comment #18) > why is this left open? do we have additional work to do here? Nope!