Closed
Bug 97097
Opened 23 years ago
Closed 23 years ago
nsIDNSService::Resolve does not use the dns cache
Categories
(Core :: Networking: Cache, defect, P1)
Core
Networking: Cache
Tracking
()
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: bbaetz, Assigned: gordon)
References
Details
(Keywords: perf, Whiteboard: patch)
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
gagan
:
review+
gordon
:
superreview+
|
Details | Diff | Splinter Review |
The synchronous dns resolve method doesn't use the DNS cache. This is bad
because this function is used often in the PAC code, which must do a synchronous
lookup. The same host is looked up more than once in lots of pac files for
functions like isInNet, and I think that everyone assumed that the dns cache
would get this.
(Although I am going to suggest that the pac code does a one-entry cache, like
the mozillaClassic code did, to avoid unneeded xpconnect wrapping.
This seems doable in the 0.9.6 timeframe.
Target Milestone: --- → mozilla0.9.6
|
||
Comment 2•23 years ago
|
||
*** Bug 104819 has been marked as a duplicate of this bug. ***
Moving to necko performance milestone 0.9.7.
Target Milestone: mozilla0.9.6 → mozilla0.9.7
|
||
Comment 4•23 years ago
|
||
Please review the attached patch and let me know if there are problems.
|
|
||
Comment 5•23 years ago
|
||
Darin pointed out that the hash table lookup needs to be protected by the dns
lock.
Doing so.
Gagan, Darin, I just submitted a new patch for your [super-]review. Is there a
good stress test for Resolve()?
Attachment #60795 -
Attachment is obsolete: true
Attachment #61235 -
Attachment is obsolete: true
Attachment #69532 -
Attachment is obsolete: true
|
Assignee | |
Comment 10•23 years ago
|
||
Comment on attachment 70212 [details] [diff] [review]
replaces inet_ntoa() whose thread-safety is somewhat dubious.
sr=darin
Attachment #70212 -
Flags: superreview+
|
||
Comment 11•23 years ago
|
||
Comment on attachment 70212 [details] [diff] [review]
replaces inet_ntoa() whose thread-safety is somewhat dubious.
r=gagan
Attachment #70212 -
Flags: review+
|
|
Assignee | |
Comment 12•23 years ago
|
||
Patch checked in. Marking FIXED.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•