Overview Description: Refactor marionette test for support panel Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Actual Results: No such integration test for support panel Expected Results: fix criteria addressed by Evan Reproducibility: 100% Additional Information: Please refer to bug 969265 for more information.

Comment on attachment 8376982 [details] pull request redirect to github refactor to fit jshint, and only enable test without SIM custom

test passed https://travis-ci.org/mozilla-b2g/gaia/builds/19019702

Comment on attachment 8376982 [details] pull request redirect to github Can we re-enable the tests with SIM custom? I believe that we disabled them because of there is no support.json file in the resource folder. I would suggest to mock the loadJSON function and make it returns a mock object of the support information for testing.

Hi Arthur, If we could access loadJSON function in window.xxx.loadJSON. We could just do ``` client.executeScript(function() { var window = window.wrappedJSObject; window.xxx.loadJSON({ json: data }); }); ``` to let it get the json data. How do you think? But why could we not just create the json file in the resource folder? We just cannot do that technically, or?

The approach looks good! support.json is a customization option. I think mocking the function would be easier and robust in this case.

Comment on attachment 8376982 [details] pull request redirect to github It looks good.