Closed
Bug 971732
Opened 11 years ago
Closed 10 years ago
Should the DeviceStorage interface be conditionally exposed?
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
The methods on navigator are, but the interface object seems to be unconditional... Since this is all nonstandard stuff, I would prefer we either not expose the interface object at all or expose it only when the methods are exposed. Sound reasonable?
jonas, who owns this stuff?
Flags: needinfo?(jonas)
I put a full proposal in bug 900241 comment 52. I hope that answers the question here?
Flags: needinfo?(jonas)
Assignee | ||
Comment 2•11 years ago
|
||
Yes. Sounds like the interface object should be conditioned on the same thing as the methods. Who's going to own that?
Flags: needinfo?(jonas)
Don't know. We're terribly short on gecko engineers in B2G :(
Flags: needinfo?(jonas)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8546023 -
Flags: review?(jonas)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8546023 [details] [diff] [review]
Hide the DeviceStorage interface object in cases when the corresponding navigator APIs are hidden
Review of attachment 8546023 [details] [diff] [review]:
-----------------------------------------------------------------
This API also requires a permission to be used. We should use that to guard these interfaces too. But this patch is a step in the right direction.
Attachment #8546023 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Target Milestone: --- → mozilla37
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•