Frank Tang Assignee
	Description • 23 years ago

we currently load fontEncoding.properties at startup time, we should find a way 
to 
remove the need of loading it at startup time to speed up startup performance
we could 
1. build in common used pair in the cpp code, and/or
2. cache the resolved result in registry.

	jbetak@netscape.com (away - not reading bugmail)
	Comment 1 • 23 years ago

per offline discussion with ftang - tentatively reassigning to myself

	Frank Tang Assignee
	Comment 2 • 23 years ago

I refer to the code in gfx/src/windows/nsFontMetricsWin.cpp .Window specific 
code

	Frank Tang Assignee
	Comment 3 • 23 years ago

reassign to ftang

	Frank Tang Assignee
	Comment 5 • 23 years ago

jbetak, can you r= this patch ?

	jbetak@netscape.com (away - not reading bugmail)
	Comment 6 • 23 years ago

r=jbetak 

the only part I didn't understand was why FreeGlobals() had to be removed. Also 
should we get rbs' sign-off on this? I believe this is his creation...

	Frank Tang Assignee
	Comment 7 • 23 years ago

rbs- can you r= this one too ?
>the only part I didn't understand was why FreeGlobals() had to be removed. 
The code which load the property file used part of the InitGlobals(void) code.
And if we failed, we call FreeGlobal(). Now the code is move to be lazy loaded
into the system and in the mid of font enumeration. If we call FreeGlobal() in
the mid of it, I am not sure what will happen. We may release some code which
already reference to some existing object. So I think we should not FreeGlobal
if we failed. 

	rbs
	Comment 8 • 23 years ago

Looks OK. r=rbs with the following nits.

1) NS_ERROR_ABORT is intimidating and suggests gpf or something...
what about s/NS_ERROR_ABORT/NS_ERROR_NOT_AVAILABLE/g
(i.e., "special encoder is not yet available").

2)
+  return rv;
+}               <--- need blank line after this
+static nsresult
+InitGlobals(void)
+{

3)
And per local custom:
+  if(  -> "if (" everywhere

4)
Plus, no need for the return after else:
+  if(gFontEncodingProperties)
+    return gFontEncodingProperties->GetStringProperty(name, aValue);
+  else 
+    return NS_ERROR_ABORT;

	rbs
	Comment 9 • 23 years ago

s/return after else/else after return/

	Chris Waterson
	Comment 10 • 23 years ago

Looks good, but could I see a new patch that addresses rbs's comments? Thanks!

	Frank Tang Assignee
	Comment 12 • 23 years ago

rbs, I address your comment in the v2 of the patch. can you r= it . waterson,
can you sr= it ?

	rbs
	Comment 13 • 23 years ago

Comment on attachment 52826 [details] [diff] [review]
v2 of patch address rbs's review comment

r=rbs

	Chris Waterson
	Comment 14 • 23 years ago

Comment on attachment 52826 [details] [diff] [review]
v2 of patch address rbs's review comment

sr=waterson

	Frank Tang Assignee
	Comment 15 • 23 years ago

fixed and check in