we currently load fontEncoding.properties at startup time, we should find a way to remove the need of loading it at startup time to speed up startup performance we could 1. build in common used pair in the cpp code, and/or 2. cache the resolved result in registry.

per offline discussion with ftang - tentatively reassigning to myself

I refer to the code in gfx/src/windows/nsFontMetricsWin.cpp .Window specific code

reassign to ftang

jbetak, can you r= this patch ?

r=jbetak the only part I didn't understand was why FreeGlobals() had to be removed. Also should we get rbs' sign-off on this? I believe this is his creation...

rbs- can you r= this one too ? >the only part I didn't understand was why FreeGlobals() had to be removed. The code which load the property file used part of the InitGlobals(void) code. And if we failed, we call FreeGlobal(). Now the code is move to be lazy loaded into the system and in the mid of font enumeration. If we call FreeGlobal() in the mid of it, I am not sure what will happen. We may release some code which already reference to some existing object. So I think we should not FreeGlobal if we failed.

Looks OK. r=rbs with the following nits. 1) NS_ERROR_ABORT is intimidating and suggests gpf or something... what about s/NS_ERROR_ABORT/NS_ERROR_NOT_AVAILABLE/g (i.e., "special encoder is not yet available"). 2) + return rv; +} <--- need blank line after this +static nsresult +InitGlobals(void) +{ 3) And per local custom: + if( -> "if (" everywhere 4) Plus, no need for the return after else: + if(gFontEncodingProperties) + return gFontEncodingProperties->GetStringProperty(name, aValue); + else + return NS_ERROR_ABORT;

s/return after else/else after return/

Looks good, but could I see a new patch that addresses rbs's comments? Thanks!

rbs, I address your comment in the v2 of the patch. can you r= it . waterson, can you sr= it ?

Comment on attachment 52826 [details] [diff] [review] v2 of patch address rbs's review comment r=rbs

Comment on attachment 52826 [details] [diff] [review] v2 of patch address rbs's review comment sr=waterson

fixed and check in