Closed Bug 971761 Opened 11 years ago Closed 11 years ago

Enable requestWakeLock in DEBUG builds to turn our tests green

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S1 (14feb)
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: rik, Assigned: rik)

References

Details

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/16219
(deleted), text/x-github-pull-request
kgrandon
: review+
fabrice
: approval-gaia-v1.3+
Details
It was disabled in Firefox in bug 963366.
Depends on: 963366
Attachment #8374889 - Flags: review?(kgrandon)
Comment on attachment 8374889 [details] https://github.com/mozilla-b2g/gaia/pull/16219 Being that 3 people from #gaia R+ this, I am ok putting my R+ on this assuming that it turns Travis green. Thanks for saving us today! r=#gaia
Attachment #8374889 - Flags: review?(kgrandon) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Bug 963366 didn't mean to disable requestWakeLock on Firefox OS. If this is unintentional, our (Gecko's) underlying problem should be fixed. Why was this change needed?
Flags: needinfo?(anthony)
(In reply to Masatoshi Kimura [:emk] from comment #4) > Bug 963366 didn't mean to disable requestWakeLock on Firefox OS. If this is > unintentional, our (Gecko's) underlying problem should be fixed. Why was > this change needed? I believe it works for b2g, but we run our tests in Firefox. The patch in this bug enables the pref for our custom profile which is needed to run our tests. Really, we need these tests to be enabled on TBPL in the same way they work on Travis.
Flags: needinfo?(anthony)
Thanks. The product ("Firefox OS") is misleading, but has no better alternative because the "Gaia" component belongs to it.
Comment on attachment 8374889 [details] https://github.com/mozilla-b2g/gaia/pull/16219 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] 1.3 travis is failing, and needs this patch to go green. [Bug caused by] (feature/regressing bug #): https://bugzilla.mozilla.org/show_bug.cgi?id=963366 [User impact] if declined: Travis will be perma-red on the 1.3 branch, and we can't reopen gaia in this state. [Testing completed]: Tested patch locally, and it fixed the broken test. [Risk to taking this patch] (and alternatives if risky): Nothing too risky since its a debug only build change for testing purposes in firefox desktop. [String changes made]: None.
Attachment #8374889 - Flags: approval-gaia-v1.3?(fabrice)
Comment on attachment 8374889 [details] https://github.com/mozilla-b2g/gaia/pull/16219 next step is to use b2g-desktop on travis...
Attachment #8374889 - Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Rik landed this. v1.3: 5fb5f5ac12be68e056dddf55b61d7c5b6e6c5525
status-b2g-v1.3: --- → fixed
status-b2g-v1.4: --- → fixed
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: