Closed
Bug 972163
Opened 11 years ago
Closed 11 years ago
Everything.me search implementation
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8375293 [details]
Github pull request
Hi Dale, Vivien - either of you guys have time for a quick review? Thanks!
Attachment #8375293 -
Flags: review?(dale)
Attachment #8375293 -
Flags: review?(21)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8375293 [details]
Github pull request
Theres a nit on github that I cant figure out why this is no longer needed, but codewide it looks good.
I think its a large step back for usability, so we should look into fixing that asap
Attachment #8375293 -
Flags: review?(dale) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8375293 [details]
Github pull request
Thanks for the review!
Attachment #8375293 -
Flags: review?(21)
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
added some comments on Github:
https://github.com/mozilla-b2g/gaia/commit/63e6d4c7aa2c63eed482e0faa3c4fcc0f44b4e7b#commitcomment-5393294
Mainly, we should send bg 'width' and 'height' params.
You need to log in
before you can comment on or make changes to this bug.
Description
•