Martin Stránský [:stransky] (ni? me) Assignee
	Description • 10 years ago

+++ This bug was initially created as a clone of Bug #627699 +++

Gtk3 fails to load theme without gtk_settings_get_for_screen() call.

RH BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1064922
Gnome BZ: https://bugzilla.gnome.org/show_bug.cgi?id=696428

	Karl Tomlinson (:karlt)
	Comment 2 • 10 years ago

Can you add a comment to explain what side effect gtk_settings_get_for_screen() is having here, please?
I guess this a problem with the css provider for GtkStyleContext being set with a push from gtk_settings_get_for_screen() instead of GtkStyleContext initializing this when required.  How is that related to https://bugzilla.gnome.org/show_bug.cgi?id=696428?

	Benjamin Otte
	Comment 3 • 10 years ago

I don't think https://bugzilla.gnome.org/show_bug.cgi?id=696428 is related.

The bug is that GTK manages a screen's CSS in the settings object. As a result of that, the CSS is loaded when the settings result is created. Until then no theme is loaded.

So the workaround is to create the settings object, which is what the patch does.

	Karl Tomlinson (:karlt)
	Comment 4 • 10 years ago

Comment on attachment 8375526 [details] [diff] [review]
patch

The code change is fine, but please remove the reference to 696428 and add an explanation comment.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 5 • 10 years ago

Thanks! There's the updated one.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3b8d7286243

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/b3b8d7286243