Closed
Bug 972382
Opened 11 years ago
Closed 11 years ago
[GTK3] Theme is not loaded in other WM's (MATE, XFCE and so)
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #627699 +++
Gtk3 fails to load theme without gtk_settings_get_for_screen() call.
RH BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1064922
Gnome BZ: https://bugzilla.gnome.org/show_bug.cgi?id=696428
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8375526 -
Flags: review?(karlt)
|
||
Comment 2•11 years ago
|
||
Can you add a comment to explain what side effect gtk_settings_get_for_screen() is having here, please?
I guess this a problem with the css provider for GtkStyleContext being set with a push from gtk_settings_get_for_screen() instead of GtkStyleContext initializing this when required. How is that related to https://bugzilla.gnome.org/show_bug.cgi?id=696428?
Flags: needinfo?(stransky)
|
||
Comment 3•11 years ago
|
||
I don't think https://bugzilla.gnome.org/show_bug.cgi?id=696428 is related.
The bug is that GTK manages a screen's CSS in the settings object. As a result of that, the CSS is loaded when the settings result is created. Until then no theme is loaded.
So the workaround is to create the settings object, which is what the patch does.
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8375526 [details] [diff] [review]
patch
The code change is fine, but please remove the reference to 696428 and add an explanation comment.
Attachment #8375526 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Updated•11 years ago
|
Attachment #8375526 -
Attachment is obsolete: true
|
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•