Closed Bug 972397 Opened 11 years ago Closed 11 years ago

Wrong locking logic in BufferTextureClient

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file)

Fix BufferTextureClient::Lock
(deleted), patch
jrmuizel
: review+
Details | Diff | Splinter Review
mLocked is set to true before we are certain that lock will actually succeed. This can lead to locking to fail while the texture thinks it is locked and trigger a wrong assertion later (typically next time we try to lock, or when we try to destroy the texture).
Attached patch Fix BufferTextureClient::Lock (deleted) — — Splinter Review
Assignee: nobody → nical.bugzilla
Attachment #8375546 - Flags: review?(jmuizelaar)
Attachment #8375546 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/9e7cf0b1d80c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 973192
No longer depends on: 973192
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: