Closed
Bug 972525
Opened 11 years ago
Closed 11 years ago
Some arrow panels on Windows don't have enough padding
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jaws, Assigned: mikedeboer)
References
Details
(Keywords: regression, Whiteboard: [Australis:P2][good first verify])
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
dao
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Screenshot of bug
See attached screenshot. This is a recent regression.
|
Reporter | |
Updated•11 years ago
|
status-firefox29:
--- → affected
status-firefox30:
--- → affected
tracking-firefox29:
--- → ?
Hardware: x86_64 → All
|
Assignee | |
Comment 1•11 years ago
|
||
Regression from my bug, I should fix this. Thanks for spotting this.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Whiteboard: [Australis:P2]
|
|
Assignee | |
Comment 2•11 years ago
|
||
But isn't the summary a tad too generic? I assume you didn't notice this for all arrowpanels, did you?
|
|
Reporter | |
Comment 3•11 years ago
|
||
It's not just on the add-ons arrowpanel. I've seen it on others too, just this was the easiest to reproduce.
|
||
Updated•11 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
|
|
Assignee | |
Comment 4•11 years ago
|
||
Dão, I believe that this is about regressions in individual browser panels, not about the toolkit theme. We need to adjust the panel elements that were already using negative margins to look more compact.
|
|
||
Updated•11 years ago
|
Component: Themes → Theme
Product: Toolkit → Firefox
Summary: Arrow panels on Windows don't have enough padding → Some arrow panels on Windows don't have enough padding
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8376191 -
Flags: review?(dao)
|
|
Assignee | |
Updated•11 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
|
|
||
Updated•11 years ago
|
Attachment #8376191 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Thanks!
Pushed as https://hg.mozilla.org/integration/fx-team/rev/677aae2a3fec
Whiteboard: [Australis:P2] → [Australis:P2][fixed-in-fx-team]
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][fixed-in-fx-team] → [Australis:P2]
Target Milestone: --- → mozilla30
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 8376191 [details] [diff] [review]
Patch v1: update notifications close button alignment
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 961727
User impact if declined: User will notice incorrect layouts on various panels on Windows as can be seen in attachment 8375721 [details].
Testing completed (on m-c, etc.): baked on m-c for 2 days
Risk to taking this patch (and alternatives if risky): minor
String or IDL/UUID changes made by this patch: n/a
Attachment #8376191 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
Attachment #8376191 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 9•11 years ago
|
||
|
||
Updated•11 years ago
|
Whiteboard: [Australis:P2] → [Australis:P2][good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•