Closed
Bug 972550
Opened 11 years ago
Closed 11 years ago
Sync promo footer in bookmarks panel overflows panel content
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 30
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
Details
(Keywords: regression, Whiteboard: [Australis:P2])
Attachments
(1 file)
(deleted),
patch
|
mak
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As mentioned by Stephen at https://bugzilla.mozilla.org/show_bug.cgi?id=961727#c18
See screenshot: http://cl.ly/image/2A0g0Y2O410j
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Stephen, how do I get to see this Sync promo footer?
Flags: needinfo?(shorlander)
Comment 2•11 years ago
|
||
check in about:config for browser.syncPromoViewsLeftMap = {"passwords":0,"bookmarks":0,"addons":4}
pump up the number to a positive one (by default it's 5) for the kind of promo you want to see, or just clear user pref.
Open one of these panels.
1. remember password doorhanger
2. star panel
3. add-on install
Note: the promo panel is visible only on profile that didn't setup Sync/FxAccount.
Flags: needinfo?(shorlander)
Assignee | ||
Comment 3•11 years ago
|
||
Thanks Marco! Since you know this in considerable detail, are you the man to review this patch?
I'd be much obliged.
Attachment #8376274 -
Flags: review?(mak77)
Comment 4•11 years ago
|
||
Comment on attachment 8376274 [details] [diff] [review]
Patch v1: adjust margins of panel promo footer on Windows
Review of attachment 8376274 [details] [diff] [review]:
-----------------------------------------------------------------
it looks good, just in case I verified on other platforms, but the original bug only changed Windows so this should be enough
Attachment #8376274 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Thanks, Marco!
https://hg.mozilla.org/integration/fx-team/rev/f4cc44651ceb
Whiteboard: [Australis:P2] → [Australis:P2][fixed-in-fx-team]
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8376274 [details] [diff] [review]
Patch v1: adjust margins of panel promo footer on Windows
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 961727
User impact if declined: Promo footers in panels will overflow the panel edges, the new Sync promo footer being the most prominent example.
Testing completed (on m-c, etc.): now on fx-team, will land on aurora after m-c is green.
Risk to taking this patch (and alternatives if risky): minor
String or IDL/UUID changes made by this patch: n/a
Attachment #8376274 -
Flags: approval-mozilla-aurora?
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][fixed-in-fx-team] → [Australis:P2]
Target Milestone: --- → Firefox 30
Updated•11 years ago
|
Attachment #8376274 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
status-firefox29:
--- → fixed
status-firefox30:
--- → fixed
Updated•11 years ago
|
QA Contact: cornel.ionce
Comment 9•11 years ago
|
||
User Agents:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Mozilla/5.0 (Windows NT 6.1; rv:30.0) Gecko/20100101 Firefox/30.0
Confirming the fix on latest Aurora (build ID: 20140313004000) and latest Nightly (build ID: 20140313030202).
Marking this issue verified.
You need to log in
before you can comment on or make changes to this bug.
Description
•