Closed
Bug 973111
Opened 11 years ago
Closed 4 years ago
Move NativeWindow.context menus to a jsm
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: wesj, Unassigned)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
It would be nice for everyone, if the NativeWindow apis could be used without needing a window object. As a start (along with other refactoring work for quick share in context menus), I want to move NativeWindow.contextmenus to a jsm. We can provide a shim in browser.js so that everything there continues to work as normal.
Reporter | ||
Comment 1•11 years ago
|
||
This is a straight move. Fennec won't work with this. We'll have to fold it with patch 2 when landing.
Attachment #8376596 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 2•11 years ago
|
||
This fixes things up so that context menus continue to work like normal.
Attachment #8376597 -
Flags: review?(mark.finkle)
Comment 3•11 years ago
|
||
Comment on attachment 8376597 [details] [diff] [review]
Patch 2/2 - Make it work
I want to take a slightly different approach to this refactor. I also don't want this to block any Quick Share work.
Let's regroup after the QuickShare work is done
Attachment #8376597 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #8376596 -
Flags: review?(mark.finkle)
Comment 4•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•