Open
Bug 97321
Opened 23 years ago
Updated 2 years ago
No way to specify only applications can be chosen in file picker
Categories
(Core :: XUL, enhancement, P3)
Tracking
()
NEW
mozilla1.4beta
People
(Reporter: mikepinkerton, Unassigned)
References
(Depends on 1 open bug, Blocks 3 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
law
:
review+
bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
The filepicker doesn't let you say 'only pick applications' so we end up passing
"*" as the filter all over the code which lets you pick _any file_, apps
included. This allows the user to do wonderful things like tell mozilla to open a
file with the application being some random text file on their disk.
Comment 1•23 years ago
|
||
This is tricky... unlike other types of files, there is no standard extension
for applications (except on windows). We could just add an applications flag to
the possible filters and leave it up to the various filepicker implementations
to figure out what to do with it. Windows is pretty easy, unix would require
checking for +x permission, not sure about mac.
Reporter | ||
Comment 2•23 years ago
|
||
mac has several mechanisms for determining if something is an app. that's not
hard.
Comment 3•23 years ago
|
||
This should be easy & worthwhile on all platforms. ->bryner p3/enhancement/096
Assignee: trudelle → bryner
Severity: normal → enhancement
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6
Updated•23 years ago
|
Status: NEW → ASSIGNED
Updated•23 years ago
|
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Comment 5•23 years ago
|
||
What we really need is an application picker, similar to what the Finder and
Windows Explorer display for unknown document types. Users should not have to
pick apps using the file system, a flat list (with icons) is much better.
Comment 6•23 years ago
|
||
Hrmm. That would require us to trawl through all the users's mounted drives,
hunting for applications. That's hugely expensive on platforms like Mac where
there is no registry to help you. (Ever regretted hitting the Change button for a
Helper app in the Internet control panel?)
Comment 7•23 years ago
|
||
Add an 'ers' onto 'us' and you have my point. On some platforms, doing the right
thing may be prohibitively expensive, and we may have to be expedient. That
doesn't mean we have to make all users do the work everywhere.
Comment 9•23 years ago
|
||
This implements "Applications" as a filter type on Unix and Windows (the Mac
filepicker implementation doesn't support filtering of any kind at present). I
used a special file extension, "..apps", which the user never sees but which
the filepicker should recognize and transform into the appropriate filtering
mechanism for that platform.
Comment 10•23 years ago
|
||
pink, do you think you could make the necessary changes on mac?
Reporter | ||
Comment 11•23 years ago
|
||
dagley should do it, i think he has time
the mac does do filtering, it's just all internal. the user can't affect it.
Comment 12•23 years ago
|
||
Isn't there a way we can display the application picker that Windows displays
when you open an unknown file type?
Comment 13•23 years ago
|
||
I imagine we could, but that shouldn't be part of the nsIFilePicker interface.
I'd imagine a new nsIAppPicker service that's implemented where available, and
then fall back to creating a file picker with the apps filter.
Updated•23 years ago
|
Comment 15•23 years ago
|
||
Comment on attachment 69436 [details] [diff] [review]
patch
r=law
Definitely an improvement.
Attachment #69436 -
Flags: review+
Comment 16•23 years ago
|
||
Comment on attachment 69436 [details] [diff] [review]
patch
sr=blake
Attachment #69436 -
Flags: superreview+
Comment 17•23 years ago
|
||
per conversation with law, we decided to also include *.com in the extension
list for Windows.
Comment 18•23 years ago
|
||
Once the Windows and *nix versions land re-assign to sdagley for the Mac fun
Comment 19•23 years ago
|
||
shouldn't this be plussed since it blocks bug 128667, which has been plussed?
thus renominating.
Comment 21•23 years ago
|
||
nsbeta1- per Nav triage team, ->1.2
Comment 22•23 years ago
|
||
It looks like this patch needs to be updated to include Mac, now that Mac
supports a filter list. Steve, do you think you could do that, or give me a
pointer on how to do it?
Comment 23•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 24•23 years ago
|
||
rather, reopening and -> dagley for mac impl
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•23 years ago
|
OS: All → MacOS X
Hardware: All → Macintosh
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → mozilla1.2beta
Updated•22 years ago
|
Target Milestone: mozilla1.2beta → mozilla1.3alpha
Comment 26•22 years ago
|
||
Since I don't report into Internet Technologies anymore this bug needs a new
owner -> saari
Assignee: sdagley → saari
Comment 28•22 years ago
|
||
Taking for 1.4b. If we need this sooner, let me know.
Status: NEW → ASSIGNED
Target Milestone: mozilla1.3alpha → mozilla1.4beta
Comment 29•22 years ago
|
||
This is not just a matter of filtering... in "Pick an application" mode we need
to behave very differently in a number of ways. See bug 82860 and bug 185831
for some examples... (and on Windows, eg, we should put up the platform app picker).
Could the Mac version also set the default location to be '/Applications' now
that we're only running on OSX?
Updated•15 years ago
|
QA Contact: bugzilla → xptoolkit.widgets
Comment 31•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: ccarlen → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•