Closed
Bug 973313
Opened 11 years ago
Closed 11 years ago
mach build installer doesn't include vccorlib120.dll on VC12 with --enable-metro and WIN32_REDIST_DIR is specified
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Because vccorlib120.dll is not copied to $objdir/dist/bin.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8376798 -
Flags: review?(robert.strong.bugs)
Comment 2•11 years ago
|
||
Comment on attachment 8376798 [details] [diff] [review]
patch
Let's ask Jim for review since he has been working on metro
Attachment #8376798 -
Flags: review?(robert.strong.bugs) → review?(jmathies)
Updated•11 years ago
|
Component: General → Build Config
Product: Firefox → Core
Updated•11 years ago
|
Summary: mach build installer fails on VC12 with --enable-metro and WIN32_REDIST_DIR is specified → mach build installer doesn't include vccorlib120.dll on VC12 with --enable-metro and WIN32_REDIST_DIR is specified
Comment 3•11 years ago
|
||
We shouldn't need this library anymore. In fact this reference can be removed -
http://mxr.mozilla.org/mozilla-central/source/browser/installer/package-manifest.in#102
Assignee | ||
Comment 4•11 years ago
|
||
OK, let's remove it.
Attachment #8376798 -
Attachment is obsolete: true
Attachment #8376798 -
Flags: review?(jmathies)
Attachment #8377116 -
Flags: review?(jmathies)
Updated•11 years ago
|
Attachment #8377116 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•