Closed Bug 973374 Opened 11 years ago Closed 11 years ago

complete speex_resampler_reset_mem

Categories

(Core :: Web Audio, defect, P2)

26 Branch
x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

sample_frac_num is the array most likely to be non-zero after resampling a previous stream, but the other arrays can also be left at non-zero values in other situations. Using a previous sample_frac_num may can mean that the first input sample is ignored. This may usually not be significant, but may just be detectable when only one channel of a stereo signal is affected.
Priority: -- → P2
Attached patch patch (deleted) — Splinter Review
I still need to modify update.sh. Please let me know if and what you'd like me to do to upstream this to opus-tools.
Attachment #8376864 - Flags: review?(jmvalin)
(In reply to Karl Tomlinson (:karlt) from comment #0) > Using a previous sample_frac_num may can mean that the first input sample is > ignored. Not ignored, but skipped.
Comment on attachment 8376864 [details] [diff] [review] patch Review of attachment 8376864 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8376864 - Flags: review?(jmvalin) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: