Closed
Bug 973374
Opened 11 years ago
Closed 11 years ago
complete speex_resampler_reset_mem
Categories
(Core :: Web Audio, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jmvalin
:
review+
|
Details | Diff | Splinter Review |
sample_frac_num is the array most likely to be non-zero after resampling a
previous stream, but the other arrays can also be left at non-zero values
in other situations.
Using a previous sample_frac_num may can mean that the first input sample is ignored. This may usually not be significant, but may just be detectable when only one channel of a stereo signal is affected.
Assignee | ||
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•11 years ago
|
||
I still need to modify update.sh.
Please let me know if and what you'd like me to do to upstream this to
opus-tools.
Attachment #8376864 -
Flags: review?(jmvalin)
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #0)
> Using a previous sample_frac_num may can mean that the first input sample is
> ignored.
Not ignored, but skipped.
Comment 3•11 years ago
|
||
Comment on attachment 8376864 [details] [diff] [review]
patch
Review of attachment 8376864 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #8376864 -
Flags: review?(jmvalin) → review+
Assignee | ||
Comment 4•11 years ago
|
||
With update.sh changes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf41db3ca50
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•