Overview Description: Refactor App permissions panel with AMD pattern referring to https://github.com/crh0716/gaia/tree/settings2_iterative to make it modularize and more easier to maintain Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Expected Results: pass all settings test and act the same as original implementation Additional Information:

waiting for travis.

Comment on attachment 8402541 [details] PR to master Hi Arthur, could you help me to review this patch? Thanks.

Comment on attachment 8402541 [details] PR to master Great work, George! Please check my github comments, thanks!

Comment on attachment 8402541 [details] PR to master Hi Arthur, patch is updated as you suggested. Please kindly check again, thanks!

Comment on attachment 8402541 [details] PR to master Thank you for working on this, George! Please check my comments in github.

Comment on attachment 8402541 [details] PR to master Hi Arthur, thanks for your reviewing. I think all issues are already addressed. Thanks. Please kindly check again.

Comment on attachment 8402541 [details] PR to master We are almost there. There are a few issue but should be easy to fix. Please check my comments, thanks!

Comment on attachment 8402541 [details] PR to master Hi Arthur, thanks for your comments, I just addressed, plz kindly check again.

Comment on attachment 8402541 [details] PR to master r=me, thank you for the effort!

Thanks Arthur, merge to master https://github.com/mozilla-b2g/gaia/commit/fab96691c62543b0277cbb28bef195f9a0bd7595

sorry, had to revert this change because it might have caused https://tbpl.mozilla.org/php/getParsedLog.php?id=38308895&tree=B2g-Inbound

Previous pr has passed travis test. It seems that tbpl has different gaia-ui test. I'll put to try server later.

George, on TBPL the size of the font is different, sometimes makes the buttons different sized. Marionette may not be tapping on the menu option correctly.

tbpl try-server: https://tbpl.mozilla.org/?tree=Try&rev=2d0830cc7328

merge to master again, https://github.com/mozilla-b2g/gaia/pull/18565

Sorry George, I have to revert your patch because yours got overlapped with mine (got backedout with one test failure). Commit: 972ea2e91ed2938fc1a35672cc9047c0e51d4364

PR again.

Merge to master, https://github.com/mozilla-b2g/gaia/commit/cadddcac2b8ce162a5e27e6dc105557b00a94478