Closed
Bug 973455
Opened 11 years ago
Closed 10 years ago
[settings] refactor SIM security panel with AMD pattern
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: eragonj)
References
Details
Attachments
(1 file)
Overview Description:
Refactor SIM sicurity panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative
to make it modularize and more easier to maintain
Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings
Expected Results:
pass all settings test and act the same as original implementation
Additional Information:
|
Assignee | |
Comment 2•10 years ago
|
||
WIP patch for 2.2
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8519746 [details]
patch on master (2.2)
Arthur, I totally forgot to set r? on you xd . please help me check this patch, thanks !
Attachment #8519746 -
Flags: review?(arthur.chen)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8519746 [details]
patch on master (2.2)
Looks good to me. But there is one issue that the sim card index is not shown correctly. Please check my comments in github, thanks.
Attachment #8519746 -
Flags: review?(arthur.chen)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8519746 [details]
patch on master (2.2)
All comments are addressed ! Thanks Arthur :)
Attachment #8519746 -
Flags: review?(arthur.chen)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8519746 [details]
patch on master (2.2)
r=me, thanks.
Attachment #8519746 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Thanks all, merged at https://github.com/mozilla-b2g/gaia/commit/c428ab85656394824ea732a95e79e069fe433f5a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•