Closed
Bug 973727
Opened 11 years ago
Closed 10 years ago
Unhide browser toolbar when reaching the end of the page
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox34 verified)
VERIFIED
FIXED
Firefox 34
| Tracking | Status | |
|---|---|---|
| firefox34 | --- | verified |
People
(Reporter: rnewman, Assigned: rahul.parsani, Mentored)
References
Details
(Whiteboard: [lang=java][good second bug])
Attachments
(1 file)
|
(deleted),
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
A la Pocket: when you scroll all the way to the bottom of the page, particularly in Reader Mode, there's a good chance you're going to want to do something else. It feels backwards to have to scroll up some distance to get primary UI to reappear.
How about we consider unhiding the toolbar when you slam into the bottom of the page?
There are some edge cases to consider, but figured I'd raise the idea.
Flags: needinfo?(ibarlow)
|
||
Comment 1•11 years ago
|
||
I like that idea. Make it so.
Related: (since you mentioned Reader Mode navigation) bug 871593
Flags: needinfo?(ibarlow)
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [shovel ready]
|
|
Reporter | |
Comment 2•10 years ago
|
||
Chaps, please unlist yourself as mentors if you're not willing and able!
Mentor: lucasr.at.mozilla, wjohnston
Whiteboard: [shovel ready] → [lang=java][good second bug]
|
Assignee | |
Comment 3•10 years ago
|
||
Added another if check in onPanZoomStopped to check whether the user has reached the end of the page. Updated the comment too.
Attachment #8470490 -
Flags: review+
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8470490 -
Flags: review+ → review?(wjohnston)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8470490 [details] [diff] [review]
973727.patch
Review of attachment 8470490 [details] [diff] [review]:
-----------------------------------------------------------------
I like this I think. Nice work. Thanks :)
Attachment #8470490 -
Flags: review?(wjohnston) → review+
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Assignee: nobody → rahul.parsani
Keywords: checkin-needed
Whiteboard: [lang=java][good second bug] → [lang=java][good second bug][fixed-in-fx-team]
|
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good second bug][fixed-in-fx-team] → [lang=java][good second bug]
Target Milestone: --- → Firefox 34
|
||
Comment 7•10 years ago
|
||
Thanks Rahul!
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•