Closed
Bug 974286
Opened 11 years ago
Closed 11 years ago
Remove mSelected from PromptListAdapter.java
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
Prompts keep their own list of selected items, separate from the ListView. They also hold a list of promptlistitems. We don't need both. We should just use the promptlist items to keep track of what's checked.
This helps with the transition to GeckoMenuItems as well (bug 943568).
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Refactored with a little cleanup.
Attachment #8378112 -
Attachment is obsolete: true
Attachment #8378694 -
Flags: review?(bnicholson)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8378694 [details] [diff] [review]
Patch
Review of attachment 8378694 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, much cleaner.
Attachment #8378694 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•