Closed
Bug 974322
Opened 11 years ago
Closed 11 years ago
Separate AAC/AVC to other items
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: ayang, Assigned: ayang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
AVC and VP8 use the same items, I_FRAME, B_FRAME and P_FRAME. It should be able to distinguish. Same problem for AUDIO_FRAME.
[1] http://dxr.mozilla.org/mozilla-central/source/content/media/encoder/EncodedFrameContainer.h#50
|
Assignee | |
Updated•11 years ago
|
Blocks: MediaEncoder
|
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → ayang
Attachment #8378190 -
Flags: review?(cpearce)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8378190 [details] [diff] [review]
rename_avc_aac_name
Review of attachment 8378190 [details] [diff] [review]:
-----------------------------------------------------------------
Should you also add a major type as well (VP8, AVC, AAC, AMR), so you can distinguish a VP8 I-Frame from a AVC I-frame?
|
|
||
Updated•11 years ago
|
Attachment #8378190 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yes, this patch updated VP8 as well.
Carry r+.
Attachment #8378190 -
Attachment is obsolete: true
Attachment #8380465 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
carry r+
Attachment #8380465 -
Attachment is obsolete: true
Attachment #8380473 -
Flags: review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
|
||
Updated•11 years ago
|
Component: Video/Audio → Video/Audio: Recording
You need to log in
before you can comment on or make changes to this bug.
Description
•