Closed
Bug 974361
Opened 11 years ago
Closed 11 years ago
Memory average assumes the array of measurements always exists
Categories
(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S2 (28feb)
People
(Reporter: stas, Assigned: stas)
References
Details
(Keywords: perf, Whiteboard: [c=automation p= s=2014.02.28 u=])
Attachments
(1 file)
A follow-up to bug 972440. It looks like some perf tests don't measure the memory at all so it's not safe to assume that there always will be an array of measurements to calculate the average from.
|
||
Comment 1•11 years ago
|
||
I noticed it too.
|
Assignee | |
Comment 2•11 years ago
|
||
Assignee: nobody → stas
Attachment #8378299 -
Flags: review?(hub)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8378299 [details]
Patch
r=me
Thanks !
Attachment #8378299 -
Flags: review?(hub) → review+
|
|
||
Comment 4•11 years ago
|
||
Merged
https://github.com/mozilla-b2g/gaia/commit/3ec31d442283e425a378a6ac4e9a38b0c6dc46d3
Thanks !
(was blocking bug 962040 in the end)
|
|
||
Updated•11 years ago
|
Target Milestone: --- → 1.4 S2 (28feb)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks for landing this for me Hubert. With the last week's gaia tree closure I wasn't sure when the right moment to merge it would be.
|
||
Updated•11 years ago
|
Whiteboard: [c=automation p= s= u=] → [c=automation p= s=2014.02.28 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•