Closed
Bug 974739
Opened 11 years ago
Closed 11 years ago
Unable to compile non-threadsafe js shells using --disable-threadsafe
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: gkw, Assigned: terrence)
References
Details
Attachments
(2 files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Bug 964059 caused a build failure for --disable-threadsafe builds.
autoBisect shows this is probably related to the following changeset:
The first bad revision is:
changeset: http://hg.mozilla.org/mozilla-central/rev/d2c4ae312b66
user: Brian Hackett
date: Wed Feb 19 09:02:13 2014 -0700
summary: Bug 964059 - Share atoms compartment/zone between multiple runtimes, r=billm,bent.
Configure parameters:
CC="clang -Qunused-arguments" AR=ar CXX="clang++ -Qunused-arguments" sh ./configure --target=x86_64-apple-darwin12.5.0 --enable-optimize --enable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inference --disable-tests --enable-more-deterministic --enable-exact-rooting --with-ccache --disable-threadsafe
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8378763 -
Flags: review?(bhackett1024)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8378763 [details] [diff] [review]
fix_thread_unsafe_build_errors-v0.diff
Review of attachment 8378763 [details] [diff] [review]:
-----------------------------------------------------------------
Oops, sorry.
Attachment #8378763 -
Flags: review?(bhackett1024) → review+
|
Reporter | |
Comment 3•11 years ago
|
||
I helped to land this:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abfaf0ccae19
Thanks a lot!
Assignee: nobody → terrence
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla30
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•