Closed Bug 974929 Opened 11 years ago Closed 11 years ago

Tweak TBPL job ordering

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(2 files, 2 obsolete files)

The test ordering is a bit random at the moment. We have Cpp/Jit tests in the middle of a bunch of others, Jetpack tacked on to the end, etc. I'm going to reorder the test suites so that we at least have some sort of alphabetical order. On a high level, I'll enforce a Builds->Unit Tests->Perf Tests ordering.
Attached patch alphabetize unit tests (obsolete) (deleted) — Splinter Review
This is a straight-up alphabetization of the unit test jobs and making sure they're all ahead of talos. The one break from this patter is that the Mozbase tests come before other unit tests as they're kind of a "bridge" test suite since many others derive from it and bustage to that is likely to hit others as well.

This leaves the unknown jobs at the end as that makes the most sense from a visibility standpoint IMO.
Attachment #8379038 - Flags: review?(emorley)
Attached patch alphabetize unit tests (obsolete) (deleted) — Splinter Review
Scratching one more itch, this fixes the SM ordering.
Attachment #8379038 - Attachment is obsolete: true
Attachment #8379038 - Flags: review?(emorley)
Attachment #8379043 - Flags: review?(emorley)
Attached patch alphabetize unit tests (deleted) — Splinter Review
Now with the right patch attached...
Attachment #8379043 - Attachment is obsolete: true
Attachment #8379043 - Flags: review?(emorley)
Attachment #8379137 - Flags: review?(emorley)
Comment on attachment 8379137 [details] [diff] [review]
alphabetize unit tests

\o/ :-)
Attachment #8379137 - Flags: review?(emorley) → review+
Depends on: 976169
In production :)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
I'm wondering if we could tweak the tbpl job ordering back slightly so that the mochitest jobs are lined up properly again - since it's visually quite distracting now with some (but crucially not all) rows having cpp etc bump the mochitest jobs along.

Perhaps:
B  M ( ...) R (...) anything-loose   T (...)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8381597 - Flags: review?(emorley)
Comment on attachment 8381597 [details] [diff] [review]
put mochitests and reftests first

Maybe also add a comment/heading, similar to the generic ones already in Data.js? (Just thinking of when other people add rows).
Attachment #8381597 - Flags: review?(emorley) → review+
Depends on: 976771
In production.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: