Closed
Bug 975064
Opened 11 years ago
Closed 11 years ago
App Manager doesn't handle disconnection well
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox29 unaffected, firefox30 verified)
VERIFIED
FIXED
Firefox 30
Tracking | Status | |
---|---|---|
firefox29 | --- | unaffected |
firefox30 | --- | verified |
People
(Reporter: janx, Assigned: jryans)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
- Connect App Manager to device
- Debug an app
- Unplug/replug the cable
- Connect to device again
- Try to debug the same app
Observed:
- No side tab is opened for the app, no toolbox is shown, the background is grey
- Debugging other apps works
Expected:
- Debugging the same app again after disconnect should work
Assignee | ||
Comment 1•11 years ago
|
||
The app actor front caches targets when you connect to an app. It uses the target's close event to remove the target from its cache.
However, the target close event was not being triggered if the client is closed out from under the target, so now the target watches for this.
Try: https://tbpl.mozilla.org/?tree=Try&rev=3575fc05f978
Comment 2•11 years ago
|
||
Comment on attachment 8381921 [details] [diff] [review]
Close target when client is closed
Review of attachment 8381921 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch!
::: browser/devtools/framework/target.js
@@ +385,5 @@
> /**
> * Teardown listeners for remote debugging.
> */
> _teardownRemoteListeners: function TabTarget__teardownRemoteListeners() {
> + this.client.removeListener("closed", this.destroy);
You could have used addOneTimeListener and avoided this if you wanted.
Attachment #8381921 -
Flags: review?(past) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
Blocks: 918695
Keywords: regression
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8381921 [details] [diff] [review]
Close target when client is closed
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 918695
User impact if declined: App Manager broken when attempting to re-debug an app after getting disconnected, requires restarting Firefox to fix
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None
Attachment #8381921 -
Flags: approval-mozilla-beta?
Attachment #8381921 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•11 years ago
|
status-firefox27:
--- → affected
status-firefox28:
--- → affected
status-firefox29:
--- → affected
status-firefox30:
--- → fixed
Assignee | ||
Comment 6•11 years ago
|
||
Hmm, never mind, seems only Firefox 30 is affected. Regression must have been triggered by some other change then.
status-firefox27:
affected → ---
status-firefox28:
affected → ---
Assignee | ||
Updated•11 years ago
|
Attachment #8381921 -
Flags: approval-mozilla-beta?
Attachment #8381921 -
Flags: approval-mozilla-aurora?
Comment 7•11 years ago
|
||
Reproduced using Firefox OS 1.2 simulator.
Verified fixed on latest Aurora 20140423004003.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•